Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid usage of RocksDB deleteRange() in DbLedgerStorage #1620

Closed
wants to merge 1 commit into from
Closed

Avoid usage of RocksDB deleteRange() in DbLedgerStorage #1620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 55 additions & 10 deletions ...per-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.nio.file.FileSystems;
import java.util.Map.Entry;
import java.util.Set;
import java.util.concurrent.TimeUnit;

import org.apache.bookkeeper.bookie.Bookie;
import org.apache.bookkeeper.bookie.EntryLocation;
Expand Down Expand Up @@ -188,6 +189,8 @@ public void delete(long ledgerId) throws IOException {
deletedLedgers.add(ledgerId);
}

private static final int DELETE_ENTRIES_BATCH_SIZE = 100000;

public void removeOffsetFromDeletedLedgers() throws IOException {
LongPairWrapper firstKeyWrapper = LongPairWrapper.get(-1, -1);
LongPairWrapper lastKeyWrapper = LongPairWrapper.get(-1, -1);
Expand All @@ -200,6 +203,10 @@ public void removeOffsetFromDeletedLedgers() throws IOException {
}

log.info("Deleting indexes for ledgers: {}", ledgersToDelete);
long startTime = System.nanoTime();
long deletedEntries = 0;
long deletedEntriesInBatch = 0;

Batch batch = locationsDb.newBatch();

try {
Expand All @@ -211,20 +218,58 @@ public void removeOffsetFromDeletedLedgers() throws IOException {
firstKeyWrapper.set(ledgerId, 0);
lastKeyWrapper.set(ledgerId, Long.MAX_VALUE);

batch.deleteRange(firstKeyWrapper.array, lastKeyWrapper.array);
}
Entry<byte[], byte[]> firstKeyRes = locationsDb.getCeil(firstKeyWrapper.array);
if (firstKeyRes == null || ArrayUtil.getLong(firstKeyRes.getKey(), 0) != ledgerId) {
// No entries found for ledger
if (log.isDebugEnabled()) {
log.debug("No entries found for ledger {}", ledgerId);
}
continue;
}

batch.flush();
long firstEntryId = ArrayUtil.getLong(firstKeyRes.getKey(), 8);
long lastEntryId = getLastEntryInLedgerInternal(ledgerId);
if (log.isDebugEnabled()) {
log.debug("Deleting index for ledger {} entries ({} -> {})",
ledgerId, firstEntryId, lastEntryId);
}

// Removed from pending set
for (long ledgerId : ledgersToDelete) {
deletedLedgers.remove(ledgerId);
// Iterate over all the keys and remove each of them
for (long entryId = firstEntryId; entryId <= lastEntryId; entryId++) {
keyToDelete.set(ledgerId, entryId);
if (log.isDebugEnabled()) {
log.debug("Deleting index for ({}, {})", keyToDelete.getFirst(), keyToDelete.getSecond());
}
batch.remove(keyToDelete.array);
++deletedEntriesInBatch;
++deletedEntries;
}

if (deletedEntriesInBatch > DELETE_ENTRIES_BATCH_SIZE) {
batch.flush();
batch.clear();
deletedEntriesInBatch = 0;
}
}
} finally {
firstKeyWrapper.recycle();
lastKeyWrapper.recycle();
keyToDelete.recycle();
batch.close();
try {
batch.flush();
batch.clear();
} finally {

firstKeyWrapper.recycle();
lastKeyWrapper.recycle();
keyToDelete.recycle();
batch.close();
}
}

log.info("Deleted indexes for {} entries from {} ledgers in {} seconds", deletedEntries, ledgersToDelete.size(),
TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startTime) / 1000.0);

// Removed from pending set
for (long ledgerId : ledgersToDelete) {
deletedLedgers.remove(ledgerId);
}
}

Expand Down