Avoid releasing sent buffer to early in BookieClient mock #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the buffer was sent to more than one bookie with the mock, it would be released after being sent to the first one. Each write should retain a refCount themselves, and then release when done. Author: Ivan Kelly <ivank@apache.org> Reviewers: Sijie Guo <sijie@apache.org> This closes apache#1598 from ivankelly/double-rel-mock
sijie
approved these changes
Sep 5, 2018
|
@sijie thank you for taking a look so quickly. do you know why only Travis-CI started to validate this patch, and not ASF Jenkins ? |
|
@eolivelli not sure. jenkins jobs should start as well. |
|
@sijie as soon as Travis will turn green I will merge this patch, the fix is trivial, it is already on master. |
|
@eolivelli sure works for me |
|
rerun integration tests |
eolivelli
pushed a commit
that referenced
this pull request
Sep 5, 2018
Cherry pick tp branch-4.8 commit 6b9cbf2 from Ivan Kelly If the buffer was sent to more than one bookie with the mock, it would be released after being sent to the first one. Each write should retain a refCount themselves, and then release when done. Author: Ivan Kelly <ivankapache.org> Relates to #1598, closes #1643 Author: Ivan Kelly <ivank@apache.org> Reviewers: Sijie Guo <sijie@apache.org> This closes #1651 from eolivelli/fix/cherry-pick-mock-client-tests-errors
|
closed with b5065b9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick tp branch-4.8 commit 6b9cbf2 from Ivan Kelly
If the buffer was sent to more than one bookie with the mock, it would
be released after being sent to the first one. Each write should
retain a refCount themselves, and then release when done.
Author: Ivan Kelly ivank@apache.org
Relates to #1598, closes #1643