Modules dependencies do not need to be included in checksum Jar #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
jvrao,
ivankelly,
sijie,
jiazhai,
eolivelli and
reddycharan
sijie
approved these changes
Oct 17, 2018
|
run bookkeeper-server remaining tests |
|
run integration tests |
1 similar comment
|
run integration tests |
|
IGNORE IT CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current assembly configuration is including the jars of the modules dependency inside its own jar.
These jars are completely ignored, but they take up non trivial space.
With this change the size of
circe-checksum.jargoes from 2.8 MB to 62 KB.