Use default metric registry in Prometheus exporter #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
ivankelly,
sijie,
jiazhai,
dlg99,
eolivelli and
reddycharan
eolivelli
approved these changes
Oct 27, 2018
sijie
requested changes
Oct 28, 2018
...provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusMetricsProvider.java
Outdated
Show resolved
Hide resolved
|
run java9 tests |
|
rebuild java9 |
1 similar comment
|
rebuild java9 |
sijie
approved these changes
Nov 1, 2018
|
run integration tests |
1 similar comment
|
run integration tests |
eolivelli
approved these changes
Nov 3, 2018
|
@sijie. Do you want this on branch 4.8? |
sijie
pushed a commit
that referenced
this pull request
Nov 3, 2018
### Motivation Currently the Prometheus exporter is using a private metrics register. This doesn't work well for BK client where we want to expose in the same registry of application, or when we want to interact with other tools that use the default static registry (eg: log4j, jetty integrations for prometheus). Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes #1765 from merlimat/prometheus
sijie
pushed a commit
that referenced
this pull request
Nov 3, 2018
### Motivation Currently the Prometheus exporter is using a private metrics register. This doesn't work well for BK client where we want to expose in the same registry of application, or when we want to interact with other tools that use the default static registry (eg: log4j, jetty integrations for prometheus). Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes #1765 from merlimat/prometheus
|
@eolivelli yes. I was in the process of merging it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the Prometheus exporter is using a private metrics register. This doesn't work well for BK client where we want to expose in the same registry of application, or when we want to interact with other tools that use the default static registry (eg: log4j, jetty integrations for prometheus).