Reduce stack traces in logs for common cases #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
jvrao,
ivankelly,
sijie,
jiazhai,
dlg99,
eolivelli and
reddycharan
sijie
approved these changes
Oct 30, 2018
sijie
pushed a commit
that referenced
this pull request
Oct 31, 2018
### Motivation For common "error" conditions the exception message is the only important bit while the stack traces are just adding clutter the logs files. Reviewers: Andrey Yegorov <None>, Sijie Guo <sijie@apache.org> This closes #1776 from merlimat/master (cherry picked from commit b17b165) Signed-off-by: Sijie Guo <sijie@apache.org>
sijie
pushed a commit
that referenced
this pull request
Oct 31, 2018
### Motivation For common "error" conditions the exception message is the only important bit while the stack traces are just adding clutter the logs files. Reviewers: Andrey Yegorov <None>, Sijie Guo <sijie@apache.org> This closes #1776 from merlimat/master (cherry picked from commit b17b165) Signed-off-by: Sijie Guo <sijie@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For common "error" conditions the exception message is the only important bit while the stack traces are just adding clutter the logs files.