Cache InetSocketAddress if hostname is IPAddress #1789

reddycharan · 2018-11-06T19:03:03Z

Descriptions of the changes in this PR:

in BookieSocketAddress if IPAddress is hostname then it is okay
to cache InetSocketAddress, since the canonicalhostname of the node
dont change.

- in BookieSocketAddress if IPAddress is hostname then it is okay to cache InetSocketAddress, since the canonicalhostname of the node dont change.

eolivelli

Good.

What about adding some test case?
I am interested in having tests with ipv6 addresses for instance

merlimat · 2018-11-06T19:14:27Z

@reddycharan One other option could be to use InetSocketAddress.createUnresolved(), though I haven't tested if the cached gets updated when the name is finally resolved. If it doesn't, it might be a good solution too.

reddycharan · 2018-11-06T21:36:35Z

@merlimat we cannt use InetSocketAddress.createUnresolved() here, because InetSocketAddress.getAddress would return null if it is unresolved https://docs.oracle.com/javase/7/docs/api/java/net/InetSocketAddress.html#getAddress()

in many places in our code we would use address of InetSocketAddress -

bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java

Line 578 in 3188933

if (addr.getSocketAddress().getAddress().isLoopbackAddress()

https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/CommandHelpers.java#L44

dlg99 · 2018-11-06T22:22:34Z

bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java

@@ -38,11 +39,19 @@
    // Member fields that make up this class.
    private final String hostname;
    private final int port;
+    private final boolean isHostnameIPAddress;
+    private final InetSocketAddress socketAddress;


I'd do Optional<InetSocketAddress>
assign Optional.empty() if it should not be cached
and use
socketAddress.orElseGet(() -> new InetSocketAddress(hostname, port)) to get address as needed.

reddycharan · 2018-11-06T23:14:48Z

@eolivelli regarding testing I'm in the same boat as Matteo here, 3d8bad4

for ipv4/ipv6 i can confirm that InetAddresses.isInetAddress handles both ipv4/ipv6 - https://github.com/google/guava/blob/master/guava/src/com/google/common/net/InetAddresses.java#L186

reddycharan · 2018-11-07T00:25:26Z

@eolivelli actually i just noticed that our current code wouldn't work with IPV6 address format, https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java#L50 here (and other places) we are assuming that COLON is the separator between bookie hostname/ipaddress and port in the bookieid.

but in the ipv6 format ':' is used instead of '.' in its ipv6 address string representation - for eg - 2001:db8:85a3:0:0:8a2e:370:7334

sijie · 2018-11-07T00:27:54Z

fyi it is a known issue that ipv6 is not supported #1513

- addressing review comments

reddycharan · 2018-11-07T01:49:09Z

@eolivelli added basic testcases validating cache functionality.

merlimat · 2018-11-07T04:32:01Z

bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java

@@ -38,11 +40,26 @@
    // Member fields that make up this class.
    private final String hostname;
    private final int port;
+    private final boolean isHostnameIPAddress;


With “optional” the Boolean shouldn’t be needed anymore

removed boolean variable

eolivelli

I can't see the new test. Maybe you did not push

- review comments

reddycharan · 2018-11-07T18:53:41Z

@eolivelli my bad. fixed it.

merlimat

👍

sijie · 2018-11-07T20:08:00Z

run integration tests

sijie · 2018-11-07T21:14:28Z

run integration tests

dlg99 · 2018-11-07T22:10:13Z

bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java

+         * instance, if bookies are advertising hostnames and the IP change, the
+         * BK client will keep forever to try to connect to the old IP.
+         */
+        return socketAddress.orElseGet(() -> {


nit:

return socketAddress.orElseGet(() -> new InetSocketAddress(hostname, port));

multiline was suggestion from code formatter.

Descriptions of the changes in this PR: - in BookieSocketAddress if IPAddress is hostname then it is okay to cache InetSocketAddress, since the canonicalhostname of the node dont change. Reviewers: Sijie Guo <sijie@apache.org>, Enrico Olivelli <eolivelli@gmail.com>, Matteo Merli <mmerli@apache.org>, Andrey Yegorov <None> This closes #1789 from reddycharan/bookieaddressonlywhenhostname (cherry picked from commit 102475a) Signed-off-by: Sijie Guo <sijie@apache.org>

Cache InetSocketAddress if hostname is IPAddress

2144848

- in BookieSocketAddress if IPAddress is hostname then it is okay to cache InetSocketAddress, since the canonicalhostname of the node dont change.

reddycharan requested a review from merlimat November 6, 2018 19:03

eolivelli reviewed Nov 6, 2018

View reviewed changes

dlg99 reviewed Nov 6, 2018

View reviewed changes

Cache InetSocketAddress if hostname is IPAddress

7f7bb10

- addressing review comments

merlimat reviewed Nov 7, 2018

View reviewed changes

eolivelli reviewed Nov 7, 2018

View reviewed changes

Cache InetSocketAddress if hostname is IPAddress

b04e069

- review comments

merlimat approved these changes Nov 7, 2018

View reviewed changes

eolivelli approved these changes Nov 7, 2018

View reviewed changes

sijie approved these changes Nov 7, 2018

View reviewed changes

dlg99 reviewed Nov 7, 2018

View reviewed changes

dlg99 approved these changes Nov 7, 2018

View reviewed changes

sijie added this to the 4.9.0 milestone Nov 8, 2018

sijie added area/bookie area/client release/4.9.0 type/improvement labels Nov 8, 2018

sijie assigned reddycharan Nov 8, 2018

sijie merged commit 102475a into apache:master Nov 8, 2018

sijie added the release/4.8.2 label Nov 8, 2018

sijie added the release/4.7.3 label Nov 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cache InetSocketAddress if hostname is IPAddress #1789

Cache InetSocketAddress if hostname is IPAddress #1789

reddycharan commented Nov 6, 2018

eolivelli left a comment

merlimat commented Nov 6, 2018

reddycharan commented Nov 6, 2018

dlg99 Nov 6, 2018 •

edited

Loading

reddycharan Nov 7, 2018

reddycharan commented Nov 6, 2018

reddycharan commented Nov 7, 2018

sijie commented Nov 7, 2018

reddycharan commented Nov 7, 2018

merlimat Nov 7, 2018

reddycharan Nov 7, 2018

eolivelli left a comment

reddycharan commented Nov 7, 2018

merlimat left a comment

sijie commented Nov 7, 2018

sijie commented Nov 7, 2018

dlg99 Nov 7, 2018

reddycharan Nov 7, 2018

Cache InetSocketAddress if hostname is IPAddress #1789

Cache InetSocketAddress if hostname is IPAddress #1789

Conversation

reddycharan commented Nov 6, 2018

eolivelli left a comment

Choose a reason for hiding this comment

merlimat commented Nov 6, 2018

reddycharan commented Nov 6, 2018

dlg99 Nov 6, 2018 • edited Loading

Choose a reason for hiding this comment

reddycharan Nov 7, 2018

Choose a reason for hiding this comment

reddycharan commented Nov 6, 2018

reddycharan commented Nov 7, 2018

sijie commented Nov 7, 2018

reddycharan commented Nov 7, 2018

merlimat Nov 7, 2018

Choose a reason for hiding this comment

reddycharan Nov 7, 2018

Choose a reason for hiding this comment

eolivelli left a comment

Choose a reason for hiding this comment

reddycharan commented Nov 7, 2018

merlimat left a comment

Choose a reason for hiding this comment

sijie commented Nov 7, 2018

sijie commented Nov 7, 2018

dlg99 Nov 7, 2018

Choose a reason for hiding this comment

reddycharan Nov 7, 2018

Choose a reason for hiding this comment

dlg99 Nov 6, 2018 •

edited

Loading