Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes for 4.8.1 #1795

Merged
merged 8 commits into from Nov 26, 2018
Merged

Release notes for 4.8.1 #1795

merged 8 commits into from Nov 26, 2018

Conversation

eolivelli
Copy link
Contributor

@eolivelli eolivelli commented Nov 8, 2018 •
edited

Release notes for 4.8.1

The commit to review is d09296c

In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java9]: skip build on java9. ONLY skip this when ONLY changing files under documentation under site.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

sijie
sijie requested changes Nov 8, 2018
View reviewed changes
site/_config.yml Outdated
@@ -8,6 +8,7 @@ destination: local-generated
twitter_url: https://twitter.com/asfbookkeeper

versions:
- "4.8.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this down after # [next_version_placehoder]?

I think the script requires some fixes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.
The a script choose this position.
Good catch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not fixed?

site/releases.md Outdated
@@ -64,6 +64,10 @@ Client Guide | API docs

## News

### [date] Release {{ site.latest_version }} available
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as usual the day of the release.
Thank you for the reminder

@eolivelli
Copy link
Contributor Author

@sijie I have written the release date (as today).
Please check it out and approve or directly merge.
Binaries hit Maven Central and dist.apache.org.

sijie
sijie requested changes Nov 22, 2018
View reviewed changes
site/_config.yml Outdated
@@ -8,6 +8,7 @@ destination: local-generated
twitter_url: https://twitter.com/asfbookkeeper

versions:
- "4.8.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not fixed?

@sijie
Copy link
Member

sijie commented Nov 22, 2018

@eolivelli please address my comments before you merge it.

@jiazhai
Copy link
Member

jiazhai commented Nov 25, 2018

@eolivelli , Is this a good time to update this page:
http://bookkeeper.apache.org/community/releases/

@jiazhai
Copy link
Member

jiazhai commented Nov 25, 2018

Oh, Found your comments, of update this after 4.8.1.

@eolivelli eolivelli added this to the 4.9.0 milestone Nov 26, 2018
@eolivelli eolivelli self-assigned this Nov 26, 2018
@eolivelli eolivelli merged commit 1a44de7 into apache:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

Assignees

@eolivelli eolivelli

Labels
area/website release/4.9.0 type/task
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eolivelli @sijie @jiazhai @merlimat