Fixed Auth with v2 protocol #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
jvrao,
ivankelly,
sijie,
eolivelli and
reddycharan
eolivelli
requested changes
Nov 11, 2018
bookkeeper-server/src/test/java/org/apache/bookkeeper/auth/TestAuthMixed.java
Outdated
Show resolved
Hide resolved
bookkeeper-server/src/test/java/org/apache/bookkeeper/auth/TestAuthMixed.java
Outdated
Show resolved
Hide resolved
@eolivelli I think this got broken (in v2) after the changes to remove the protobuf extension mechanism for the auth message. Core problem is the test was not running with v2. |
eolivelli
approved these changes
Nov 11, 2018
sijie
approved these changes
Nov 11, 2018
sijie
pushed a commit
that referenced
this pull request
Nov 11, 2018
### Motivation BK auth framework is currently broken when using v2 protocol. ### Changes * Fixed auth when using V2 protocol * Made sure a client with authentication enabled can talk to a bookie without authentication. This is required in any case when enabling/disabling authentication on a live cluster. * Run all auth tests against both v2 and v3 protocol. This should be included in 4.7.2 to give a path to upgrade. cc/ rdhabalia Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes #1805 from merlimat/fix-v2-auth (cherry picked from commit dc2aaaa) Signed-off-by: Sijie Guo <sijie@apache.org>
sijie
pushed a commit
that referenced
this pull request
Nov 11, 2018
### Motivation BK auth framework is currently broken when using v2 protocol. ### Changes * Fixed auth when using V2 protocol * Made sure a client with authentication enabled can talk to a bookie without authentication. This is required in any case when enabling/disabling authentication on a live cluster. * Run all auth tests against both v2 and v3 protocol. This should be included in 4.7.2 to give a path to upgrade. cc/ rdhabalia Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org> This closes #1805 from merlimat/fix-v2-auth (cherry picked from commit dc2aaaa) Signed-off-by: Sijie Guo <sijie@apache.org>
|
merged to master, branch-4.8, and branch 4.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
BK auth framework is currently broken when using v2 protocol.
Changes
This should be included in 4.7.2 to give a path to upgrade.
cc/ @rdhabalia