Allow to configure BK for low latency busy-wait settings #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you have any perf numbers to share to show what kind of perf improvements we should expect with this feature enabled? |
|
@dlg99 I have posted the numbers here: #1641 (comment) |
sijie
approved these changes
Nov 16, 2018
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/OrderedExecutor.java
Outdated
Show resolved
Hide resolved
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/OrderedExecutor.java
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
Outdated
Show resolved
Hide resolved
| @@ -602,8 +604,7 @@ BookieWatcher getBookieWatcher() { | |||
| return bookieWatcher; | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| OrderedExecutor getMainWorkerPool() { | |||
| public OrderedExecutor getMainWorkerPool() { | |||
There was a problem hiding this comment.
any reason why @VisibleForTesting annotation is removed?
|
run java8 tests |
|
run integration tests |
|
rebuild java8 |
sijie
reviewed
Dec 5, 2018
|
run integration tests |
1 similar comment
|
run integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added
enableBusyWaitconfiguration option to turn on CPU Affinity and busy wait on sockets and queues.