Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table service] add a bookie registration based grpc name resolver #1842

Merged
merged 7 commits into from
Dec 1, 2018

Conversation

sijie
Copy link
Member

@sijie sijie commented Nov 28, 2018

Descriptions of the changes in this PR:

Motivation

Table service is using grpc name resolver to figure out the alive servers serving table service.
Currently it is using default dns name resolver. In the context of Pulsar, since brokers talk
to bookies via zookeeper service discovery, it is making sense for brokers talk to table service
via zookeeper service discovery. So this PR is to add a bookie registration based grpc name resolver.

Changes

Implement a bookie-registration library based grpc name resolver.


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java9]: skip build on java9. ONLY skip this when ONLY changing files under documentation under site.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

*Motivation*

RefelectionUtils contains helpers for loading classes from relections.
It is useful across the project. However the class is in `bookkeeper-server` module only.

*Changes*

Move this class to `bookkeeper-common` module
*Motivation*

Table service is using grpc name resolver to figure out the alive servers serving table service.
Currently it is using default dns name resolver. In the context of Pulsar, since brokers talk
to bookies via zookeeper service discovery, it is making sense for brokers talk to table service
via zookeeper service discovery. So this PR is to add a bookie registration based grpc name resolver.

*Changes*

Implement a bookie-registration library based grpc name resolver.
@sijie sijie added type/feature area/tableservice changes related to table service release/4.9.0 labels Nov 28, 2018
@sijie sijie added this to the 4.9.0 milestone Nov 28, 2018
@sijie sijie self-assigned this Nov 28, 2018
@sijie
Copy link
Member Author

sijie commented Nov 28, 2018

This PR is based on #1841 since it requires RelectionUtils available in bookkeeper-common instead of bookkeeper-server module.

@merlimat : added this zookeeper based grpc name resolver for allowing a smooth upgrade in pulsar without adding hassles at configuring dns for accessing table service.

@sijie
Copy link
Member Author

sijie commented Nov 28, 2018

rebased to master after #1841 is merged.

@eolivelli
Copy link
Contributor

rerun bookkeeper-server tls tests
rerun pr validation

@sijie sijie merged commit 02f706f into apache:master Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants