-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[table service] add a bookie registration based grpc name resolver #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* RefelectionUtils contains helpers for loading classes from relections. It is useful across the project. However the class is in `bookkeeper-server` module only. *Changes* Move this class to `bookkeeper-common` module
*Motivation* Table service is using grpc name resolver to figure out the alive servers serving table service. Currently it is using default dns name resolver. In the context of Pulsar, since brokers talk to bookies via zookeeper service discovery, it is making sense for brokers talk to table service via zookeeper service discovery. So this PR is to add a bookie registration based grpc name resolver. *Changes* Implement a bookie-registration library based grpc name resolver.
rebased to master after #1841 is merged. |
rerun bookkeeper-server tls tests |
jiazhai
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Table service is using grpc name resolver to figure out the alive servers serving table service.
Currently it is using default dns name resolver. In the context of Pulsar, since brokers talk
to bookies via zookeeper service discovery, it is making sense for brokers talk to table service
via zookeeper service discovery. So this PR is to add a bookie registration based grpc name resolver.
Changes
Implement a bookie-registration library based grpc name resolver.