Issue 191: add template for ISSUE and PR #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiazhai I think these two files introduced the rate-check warnings. please either exclude them from apache-rat checking or add apache license header. |
|
@sijie Done the fix, excluded .github dir. |
eolivelli
requested changes
Jun 15, 2017
.github/ISSUE_TEMPLATE.md
Outdated
|
|
||
| **QUESTION** | ||
|
|
||
| Have you checked our documentation at http://bookkeeper.apache.org/ , If you could not find an answer there, please consider asking your question in our community forum at dev@bookkeeper.apache.org, as it would benefit other members of our community. |
There was a problem hiding this comment.
Maybe it is better to cite usr@ and not @dev
There was a problem hiding this comment.
sure, will change it to user@. Thanks.
|
+1 I will try the new script at #194 againts this pr |
|
@sijie for you is ok ? so that we can merge and start using it for new issues/pr ? |
|
LGTM +1 |
|
merging it now. |
revans2
pushed a commit
to YahooArchive/bookkeeper
that referenced
this pull request
Nov 21, 2017
YBK-174 integrate BOOKKEEPER-965: Long Polling Part I: Changes in the…
sijie
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jan 26, 2018
Descriptions of the changes in this PR: Fix checkstyle error in core module Author: Arvin <arvindevel@gmail.com> Reviewers: Sijie Guo <sijie@apache.org> This closes apache#192 from ArvinDevel/enable_check, closes apache#165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following BP-9, provide a template for ISSUE and PR.
When create issue, will use ISSUE template; while create PR will use PR template.