Issue 225: Remove Parameterized from CompactionTest #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
added a commit
to sijie/bookkeeper
that referenced
this pull request
Jan 26, 2018
…e-collected Descriptions of the changes in this PR: the problem is a new entry buffer was allocated when closing log segment writer. the entry buffer is never used and also never recycled. It causes an annoying logging. the fix is to assign a dummy entry writer which basically rejects writes, when closing a log segment writer. it would prevent leaking bytebuf. Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None> This closes apache#230 from sijie/fix_bytebuf_release_pr, closes apache#226
sijie
added a commit
to sijie/bookkeeper
that referenced
this pull request
Jan 26, 2018
Descriptions of the changes in this PR: - FileSystem API wrapper built over dlog API (This is based on initial implementation from gerritsundaram at apache#43) Features supported: - create and append files - open files for reading - input stream and output stream for reading and writing data - list files - get file status - rename - mkdir Features aren't supported: - truncate - currently there is no clear distinguish between file and dir - only support delete recursive (This change includes small changes for apache#224 apache#225 apache#226 ). Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None> This closes apache#227 from sijie/fix_create_log
rdhabalia
pushed a commit
to rdhabalia/bookkeeper
that referenced
this pull request
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR: