Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE 2377 : Relax grpcio requirement for python client to support python3.8 on mac os #2432

Conversation

ca-simone-chiorazzo
Copy link
Contributor

@ca-simone-chiorazzo ca-simone-chiorazzo commented Oct 8, 2020

Descriptions of the changes in this PR:

Require a grpcio version that is minor of 1.28. This allow to install the 1.27.2 that has a pre-compiled wheel for python 3.8 on mac os.
Add tests for python 3.8

Motivation

grpcio 1.25.0 does not allow the installation using python 3.8 on mac os x. This is due to the fact that the pre-compiled wheels have not been published before 1.26.0

Changes

Updated the setup.py to relax a bit the requirement for grpcio
Add python3.8 as tested version
Updated the setup.py to install the latest pymmh3 version. Note: master tests are broken, I've updated the library and removed the 'signed' parameter that does not exists not anymore.

Master Issue: #

cc @eolivelli


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@ca-simone-chiorazzo
Copy link
Contributor Author

Hi @sijie, thanks for the quick review. How can I request other reviewers to take a look at this? I would move it forward quickly to solve a problem in our development environment. Thanks!

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli
Copy link
Contributor

@sijie so you think it is worth to cherry pick to 4.11 and cut a new RC? Or can we wait for 4.12? Hopefully we will release it within the end of November

@ca-simone-chiorazzo
Copy link
Contributor Author

@sijie so you think it is worth to cherry pick to 4.11 and cut a new RC? Or can we wait for 4.12? Hopefully we will release it within the end of November

@sijie Sorry for the ping, could you please advice on this point? Honestly, for us, it would be better to have a new release with only this fix. Otherwise, we have to roll back the upgrade to python3.8 just for this sub-dependency. We cannot avoid it because we use pipenv to manage the dependencies

@zhavir
Copy link

zhavir commented Oct 14, 2020

Is there an ETA for this? It is a blocker also for us. Thanks

@eolivelli eolivelli added this to the 4.12.0 milestone Oct 14, 2020
@eolivelli eolivelli merged commit d3af27e into apache:master Oct 14, 2020
eolivelli pushed a commit that referenced this pull request Oct 14, 2020
…thon3.8 on mac os

Descriptions of the changes in this PR:

Require a grpcio version that is minor of 1.28. This allow to install the 1.27.2 that has a pre-compiled wheel for python 3.8 on mac os.
Add tests for python 3.8

### Motivation

grpcio 1.25.0 does not allow the installation using python 3.8 on mac os x. This is due to the fact that the pre-compiled wheels have not been published before 1.26.0

### Changes

Updated the setup.py to relax a bit the requirement for grpcio
Add python3.8 as tested version
Updated the setup.py to install the latest pymmh3 version. **Note**: master tests are broken, I've updated the library and removed the 'signed' parameter that does not exists not anymore.

Master Issue: #<master-issue-number>

cc eolivelli

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #2432 from ca-simone-chiorazzo/bugfix/2377-relax-grpcio-python-dep-for-python-3.8-on-mac-os, closes #2377

(cherry picked from commit d3af27e)
Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
@eolivelli
Copy link
Contributor

@zhavir I have merged this useful patch.

It will be available in 4.12.0 and in 4.11.2.
We don't have an estimate.

I can say that we are releasing 4.11.1 during this week, I expect 4.12.0 release within a month from today

@ca-simone-chiorazzo ca-simone-chiorazzo deleted the bugfix/2377-relax-grpcio-python-dep-for-python-3.8-on-mac-os branch October 21, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants