Issue #2908: Replace unsafe NoEntryException with IOException #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
merlimat,
hangc0276,
dlg99,
nicoloboschi,
shoothzj and
zymap
dlg99
approved these changes
Jul 28, 2022
|
ping @Vanlightly, Would you please rebase the master? thanks. |
|
ping @merlimat @eolivelli, Would you please help take a look? thanks a lot. |
hangc0276
approved these changes
Jul 28, 2022
|
LGTM |
zymap
force-pushed
the
no-such-entry-responses
branch
from
2023e56
to
f5b01bb
Compare
|
I just want to merge master branch into this, found that introduces some unnecessary commits. So I revert it. |
|
Rebase is easier than merge master, but that needs to force push the first commit. If @Vanlightly won't have time to do that, I would like to help with this PR in the next monday. |
Throwing a NoEntryException from the entry logger for an entry that the index says should exist is unsafe. It can cause ledger truncation during ledger recovery. It only takes a single false NoSuchEntry response to trigger truncation. NoEntryException should only be thrown from inside ledger storage if the entry is not found in the index.
hangc0276
force-pushed
the
no-such-entry-responses
branch
from
f5b01bb
to
af3cbff
Compare
zymap
pushed a commit
that referenced
this pull request
Aug 1, 2022
* Replace unsafe NoEntryException with IOException Throwing a NoEntryException from the entry logger for an entry that the index says should exist is unsafe. It can cause ledger truncation during ledger recovery. It only takes a single false NoSuchEntry response to trigger truncation. NoEntryException should only be thrown from inside ledger storage if the entry is not found in the index. * fix CI Co-authored-by: chenhang <chenhang@apache.org> (cherry picked from commit 966b865)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
…pache#2909) * Replace unsafe NoEntryException with IOException Throwing a NoEntryException from the entry logger for an entry that the index says should exist is unsafe. It can cause ledger truncation during ledger recovery. It only takes a single false NoSuchEntry response to trigger truncation. NoEntryException should only be thrown from inside ledger storage if the entry is not found in the index. * fix CI Co-authored-by: chenhang <chenhang@apache.org> (cherry picked from commit 966b865)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
…pache#2909) * Replace unsafe NoEntryException with IOException Throwing a NoEntryException from the entry logger for an entry that the index says should exist is unsafe. It can cause ledger truncation during ledger recovery. It only takes a single false NoSuchEntry response to trigger truncation. NoEntryException should only be thrown from inside ledger storage if the entry is not found in the index. * fix CI Co-authored-by: chenhang <chenhang@apache.org> (cherry picked from commit 966b865)
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jan 11, 2023
…pache#2909) * Replace unsafe NoEntryException with IOException Throwing a NoEntryException from the entry logger for an entry that the index says should exist is unsafe. It can cause ledger truncation during ledger recovery. It only takes a single false NoSuchEntry response to trigger truncation. NoEntryException should only be thrown from inside ledger storage if the entry is not found in the index. * fix CI Co-authored-by: chenhang <chenhang@apache.org> (cherry picked from commit 966b865) (cherry picked from commit 23355e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Throwing a NoEntryException from the entry logger
for an entry that the index says should exist is
unsafe. It can cause ledger truncation during ledger
recovery. It only takes a single false NoSuchEntry
response to trigger truncation.
NoEntryException should only be thrown from inside
ledger storage if the entry is not found in the index.
Changes
Do not throw NoEntryException from EntryLogger on failing to read entry from log file, throw IOException instead.
Master Issue: #2908