Add throttle for rebuild entryMetadataMap #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Dec 25, 2021
| // entry log | ||
| try { | ||
| return extractEntryLogMetadataFromIndex(entryLogId); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Can we catch specific exceptions here?
|
rerun failure checks |
|
rerun failure checks |
3 similar comments
|
rerun failure checks |
|
rerun failure checks |
|
rerun failure checks |
eolivelli
reviewed
Jan 5, 2022
| // First try to extract the EntryLogMetadata from the index, if there's no index then fallback to scanning the | ||
| // entry log | ||
| try { | ||
| return extractEntryLogMetadataFromIndex(entryLogId); |
There was a problem hiding this comment.
I wonder if you could add a test that injects a failure here using PowerMock and test that the bookie works even if we fall into the catch clause
|
@hangc0276 please rebase/resolve conflicts |
|
rerun failure checks |
3 similar comments
|
rerun failure checks |
|
rerun failure checks |
|
rerun failure checks |
hangc0276
force-pushed
the
chenhang/add_throttle_for_build_entryMetadataMap
branch
from
ecef7f9
to
b8b3655
Compare
hangc0276
force-pushed
the
chenhang/add_throttle_for_build_entryMetadataMap
branch
from
c695fea
to
87ef9db
Compare
dlg99
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Nov 19, 2022
When a bookie restart, the garbageCollectorThread will rebuild entryMetadataMap from all the entry log files in ledger directory. For normal case, it will extract the EntryLogMetadata from the index in entry log file. However, if there's no index, then fallback to scanning the entry log file. In user's production environment, the log files without index occupied 4%. The total entry log files is 80000, and the log files without index is 3000. The default entry log file size is 2GB, and the garbageCollectorThread will read 3000 * 2GB = 6TB data without speed limit, which will cause ledger disk IO util runs high for dozens of minutes and affect ledger read and write latency. 1. Add read speed rate limiter for scanning entry log file in entryMetadataMap rebuild. Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com> This closes apache#2963 from hangc0276/chenhang/add_throttle_for_build_entryMetadataMap (cherry picked from commit 181a6dc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a bookie restart, the garbageCollectorThread will rebuild entryMetadataMap from all the entry log files in ledger directory. For normal case, it will extract the EntryLogMetadata from the index in entry log file. However, if there's no index, then fallback to scanning the entry log file.
In user's production environment, the log files without index occupied 4%. The total entry log files is 80000, and the log files without index is 3000. The default entry log file size is 2GB, and the garbageCollectorThread will read 3000 * 2GB = 6TB data without speed limit, which will cause ledger disk IO util runs high for dozens of minutes and affect ledger read and write latency.
Modification