Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[security] Allow to enable tls on bookkeeper httpserver #2995

Merged
merged 1 commit into from Feb 25, 2022
Merged

[security] Allow to enable tls on bookkeeper httpserver #2995

merged 1 commit into from Feb 25, 2022

Conversation

shoothzj
Copy link
Member

Motivation

Allow to enable tls on bookkeeper httpserver

Changes

  • add five config param to start a jks-based tls server.
    • httpServerTlsEnable
    • httpServerKeyStorePath
    • httpServerKeyStorePassword
    • httpServerTrustStorePath
    • httpServerTrustStorePassword
  • vertx can start as tls

@shoothzj shoothzj force-pushed the bk-http-tls branch 3 times, most recently from 8c8c332 to 3ba3d2b Compare January 17, 2022 01:14
dlg99
dlg99 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you for adding the tests.

@shoothzj
Copy link
Member Author

@eolivelli @merlimat @pkumar-singh PTAL

eolivelli
eolivelli approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eolivelli
Copy link
Contributor

rerun failure checks

@shoothzj shoothzj force-pushed the bk-http-tls branch 3 times, most recently from 41cfe3a to cfa3af6 Compare February 23, 2022 12:45
@shoothzj
Copy link
Member Author

rerun failure checks

@shoothzj
Copy link
Member Author

@eolivelli could you please helping merge this?

@eolivelli eolivelli merged commit c9d218e into apache:master Feb 25, 2022
@shoothzj shoothzj deleted the bk-http-tls branch February 25, 2022 06:37
@shoothzj shoothzj mentioned this pull request May 2, 2022
Closed
@shoothzj shoothzj mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlg99 dlg99 dlg99 approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shoothzj @eolivelli @dlg99