Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set Mod initial Delay time to simply avoid GarbageCollectorThread working at the same time #3012

Merged
merged 4 commits into from Feb 22, 2022
Merged

set Mod initial Delay time to simply avoid GarbageCollectorThread working at the same time #3012

merged 4 commits into from Feb 22, 2022

Conversation

StevenLuMT
Copy link
Contributor

Descriptions of the changes in this PR:

Motivation

when number of ledger's Dir are more than 1,the same of GarbageCollectorThread will do the same thing,
Especially:

  1. deleting ledger, then SyncThread will be timed to do rocksDB compact
  2. compact: entry, cost cpu.

Changes

set a Mod initial Delay time to simply avoid GarbageCollectorThread working at the same time

eolivelli
eolivelli approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

+1

@StevenLuMT
Copy link
Contributor Author

makes sense to me

+1

thank you very mach for reviewed and approved @eolivelli

@StevenLuMT
Copy link
Contributor Author

@pkumar-singh @zymap
If you have time, please help me review it, thank you

@StevenLuMT
Copy link
Contributor Author

rerun failure checks

@StevenLuMT
Copy link
Contributor Author

@pkumar-singh @zymap
If you have time, please help me merge it, thank you

@zymap zymap merged commit 894b32a into apache:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@zymap zymap zymap approved these changes

Assignees

@StevenLuMT StevenLuMT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StevenLuMT @eolivelli @zymap