fix duplicate typeline for prometheus type #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eolivelli @dlg99 PTAL |
dlg99
approved these changes
Mar 27, 2022
eolivelli
requested changes
Mar 27, 2022
| @@ -172,6 +172,7 @@ public StatsLogger getStatsLogger(String scope) { | |||
|
|
|||
| @Override | |||
| public void writeAllMetrics(Writer writer) throws IOException { | |||
| PrometheusTextFormatUtil.reset(); | |||
There was a problem hiding this comment.
This is a sign of something going wrong.
What happens with two concurrent calls to this method?
There was a problem hiding this comment.
@eolivelli you are right, we don't know what will happen. Let me push a fix.
shoothzj
force-pushed
the
fix-duplicate-type
branch
from
1e85564
to
fdea75b
Compare
|
@eolivelli PTAL again thanks, I refractor For an alternate approach, I can add HashSet params to every method in |
shoothzj
force-pushed
the
fix-duplicate-type
branch
from
fdea75b
to
729ad13
Compare
hangc0276
pushed a commit
to streamnative/bookkeeper-achieved
that referenced
this pull request
May 30, 2023
(cherry picked from commit 38dc328)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Jun 26, 2023
(cherry picked from commit 38dc328)
|
This has already been released since 4.15.0. Remove the 4.15.x label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3136
Descriptions of the changes in this PR:
Motivation
fix duplicate typeline for prometheus type
Changes
remember the prometheus type, record in set, incase print again
Master Issue: #3136