Fix the V2 AddRequest object leak issue #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- **Motivation** If the request is a V2 add request, we retained the data's reference when creating the AddRequest object. To avoid the object leak, we need to release the reference if we met any errors before sending it.
nicoloboschi
approved these changes
Jun 9, 2022
shoothzj
approved these changes
Jun 9, 2022
hangc0276
approved these changes
Jun 10, 2022
|
Great Job! |
zymap
added a commit
that referenced
this pull request
Jun 13, 2022
--- **Motivation** If the request is a V2 add request, we retained the data's reference when creating the AddRequest object. To avoid the object leak, we need to release the reference if we met any errors before sending it. (cherry picked from commit f887f8d)
zymap
added a commit
that referenced
this pull request
Jun 13, 2022
--- **Motivation** If the request is a V2 add request, we retained the data's reference when creating the AddRequest object. To avoid the object leak, we need to release the reference if we met any errors before sending it. (cherry picked from commit f887f8d)
|
cherry-picked to branch-4.14 and branch-4.15 |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
--- **Motivation** If the request is a V2 add request, we retained the data's reference when creating the AddRequest object. To avoid the object leak, we need to release the reference if we met any errors before sending it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the request is a V2 add request, we retained the data's
reference when creating the AddRequest object. To avoid the
object leak, we need to release the reference if we met
any errors before sending it.