-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add and check indexDirs in Cookie meta #3372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work
some questions
- how do we deal with rollbacks of versions ?
- is this change backward compatible ?
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CookieIndexDirTest.java
Show resolved
Hide resolved
@eolivelli
|
there should be already a bookkeeper shell command to rewrite the cookie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yes , it's cookie_generate(class name is GenerateCookieCommand.java), I will add a param for --index-dirs |
Co-authored-by: lushiji <lushiji@didiglobal.com> (cherry picked from commit dc09182)
Co-authored-by: lushiji <lushiji@didiglobal.com>
Descriptions of the changes in this PR:
Motivation
planning for index dir: mail talking
stage 2: add and check indexDirs in cookie meta
Changes