Speed up the rebuildinding of RocksDB index #3458

merlimat · 2022-08-26T21:56:04Z

Motivation

When rebuilding RocksDB index, if we're inserting the entries one by one, we're becoming bottlenecked on the RocksDB insertion. Instead we should add items to the index in batches.

StevenLuMT · 2022-08-29T02:57:39Z

...r-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LocationsIndexRebuildOp.java

@@ -31,6 +31,9 @@
 import java.util.Date;
 import java.util.Set;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicReference;
+


new checkstyle not pass, please clean line:36 newline

hangc0276

Nice catch!

hangc0276 · 2022-09-05T01:30:43Z

Hi @merlimat, Would you please help resolve the check style issue?

Error:  /home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LocationsIndexRebuildOp.java:37:1: Extra separation in import group before 'org.apache.bookkeeper.bookie.BookieImpl' [ImportOrder]
Audit done.
[INFO] There is 1 error reported by Checkstyle 9.3 with buildtools/src/main/resources/bookkeeper/checkstyle.xml ruleset.
Error:  src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LocationsIndexRebuildOp.java:[37,1] (imports) ImportOrder: Extra separation in import group before 'org.apache.bookkeeper.bookie.BookieImpl'

eolivelli

LGTM

StevenLuMT · 2022-09-19T15:23:39Z

rerun failure checks

StevenLuMT

lgtm

* Speed up the rebuildinding of RocksDB index * fix check style Co-authored-by: chenhang <chenhang@apache.org> (cherry picked from commit 7004d99)

This reverts commit a6a4074.

zymap · 2023-02-21T02:44:56Z

This PR will cause the test to fail on branch-4.15. Remove it from 4.15.4 release.

Error log

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project bookkeeper-server: There are test failures.
[ERROR]
[ERROR] Please refer to /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server && /Volumes/work/devtools/jdk-11.0.16.jdk/Contents/Home/bin/java -Xmx2G -Djava.net.preferIPv4Stack=true -Dio.netty.leakDetection.level=paranoid --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED --add-opens java.base/java.nio.channels.spi=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.util.concurrent=ALL-UNNAMED --add-opens java.base/java.util.stream=ALL-UNNAMED --add-opens java.base/java.time=ALL-UNNAMED --add-opens java.base/jdk.internal.loader=ALL-UNNAMED --add-opens java.base/sun.net.dns=ALL-UNNAMED --add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/sun.security.jca=ALL-UNNAMED --add-opens java.xml/jdk.xml.internal=ALL-UNNAMED -jar /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server/target/surefire/surefirebooter14408819248685557633.jar /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server/target/surefire 2023-02-21T09-39-53_120-jvmRun1 surefire2887148242694623677tmp surefire_014040627733256951610tmp
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 134
[ERROR] Crashed tests:
[ERROR] org.apache.bookkeeper.bookie.storage.ldb.LocationsIndexRebuildTest
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server && /Volumes/work/devtools/jdk-11.0.16.jdk/Contents/Home/bin/java -Xmx2G -Djava.net.preferIPv4Stack=true -Dio.netty.leakDetection.level=paranoid --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED --add-opens java.base/java.nio.channels.spi=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.util.concurrent=ALL-UNNAMED --add-opens java.base/java.util.stream=ALL-UNNAMED --add-opens java.base/java.time=ALL-UNNAMED --add-opens java.base/jdk.internal.loader=ALL-UNNAMED --add-opens java.base/sun.net.dns=ALL-UNNAMED --add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/sun.security.jca=ALL-UNNAMED --add-opens java.xml/jdk.xml.internal=ALL-UNNAMED -jar /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server/target/surefire/surefirebooter14408819248685557633.jar /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server/target/surefire 2023-02-21T09-39-53_120-jvmRun1 surefire2887148242694623677tmp surefire_014040627733256951610tmp
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 134
[ERROR] Crashed tests:
[ERROR] org.apache.bookkeeper.bookie.storage.ldb.LocationsIndexRebuildTest
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:532)
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:479)
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:322)
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:266)
[ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1314)
[ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1159)
[ERROR] 	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:932)
[ERROR] 	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
[ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:370)
[ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:351)
[ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:215)
[ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:171)
[ERROR] 	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:163)
[ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
[ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
[ERROR] 	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
[ERROR] 	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
[ERROR] 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:294)
[ERROR] 	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
[ERROR] 	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
[ERROR] 	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:960)
[ERROR] 	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:293)
[ERROR] 	at org.apache.maven.cli.MavenCli.main(MavenCli.java:196)
[ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
[ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
[ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
[ERROR] 	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
[ERROR] Caused by: org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server && /Volumes/work/devtools/jdk-11.0.16.jdk/Contents/Home/bin/java -Xmx2G -Djava.net.preferIPv4Stack=true -Dio.netty.leakDetection.level=paranoid --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.nio=ALL-UNNAMED --add-opens java.base/java.nio.channels.spi=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.util.concurrent=ALL-UNNAMED --add-opens java.base/java.util.stream=ALL-UNNAMED --add-opens java.base/java.time=ALL-UNNAMED --add-opens java.base/jdk.internal.loader=ALL-UNNAMED --add-opens java.base/sun.net.dns=ALL-UNNAMED --add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/sun.security.jca=ALL-UNNAMED --add-opens java.xml/jdk.xml.internal=ALL-UNNAMED -jar /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server/target/surefire/surefirebooter14408819248685557633.jar /Volumes/work/github.com/apache/bookkeeper/bookkeeper-server/target/surefire 2023-02-21T09-39-53_120-jvmRun1 surefire2887148242694623677tmp surefire_014040627733256951610tmp
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 134
[ERROR] Crashed tests:
[ERROR] org.apache.bookkeeper.bookie.storage.ldb.LocationsIndexRebuildTest
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:748)
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.access$700(ForkStarter.java:121)
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:465)
[ERROR] 	at org.apache.maven.plugin.surefire.booterclient.ForkStarter$2.call(ForkStarter.java:442)
[ERROR] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[ERROR] 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[ERROR] 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[ERROR] 	at java.base/java.lang.Thread.run(Thread.java:834)
[ERROR]
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
(⎈|minikube:default):bookkeeper/ (branch-4.15✗) $

Speed up the rebuildinding of RocksDB index

7da28f5

rdhabalia approved these changes Aug 26, 2022

View reviewed changes

StevenLuMT reviewed Aug 29, 2022

View reviewed changes

hangc0276 approved these changes Aug 30, 2022

View reviewed changes

hangc0276 added this to the 4.16.0 milestone Aug 30, 2022

hangc0276 assigned merlimat Aug 30, 2022

hangc0276 added type/improvement area/bookie labels Aug 30, 2022

shoothzj approved these changes Sep 5, 2022

View reviewed changes

fix check style

ee68c4c

eolivelli approved these changes Sep 14, 2022

View reviewed changes

StevenLuMT approved these changes Sep 19, 2022

View reviewed changes

merlimat merged commit 7004d99 into apache:master Sep 19, 2022

zymap added the release/4.15.4 label Feb 16, 2023

zymap pushed a commit that referenced this pull request Feb 16, 2023

Speed up the rebuildinding of RocksDB index (#3458)

a6a4074

* Speed up the rebuildinding of RocksDB index * fix check style Co-authored-by: chenhang <chenhang@apache.org> (cherry picked from commit 7004d99)

zymap added the cherry-picked/branch-4.15 label Feb 17, 2023

zymap added a commit to zymap/bookkeeper that referenced this pull request Feb 21, 2023

Revert "Speed up the rebuildinding of RocksDB index (apache#3458)"

d93069d

This reverts commit a6a4074.

zymap removed cherry-picked/branch-4.15 release/4.15.4 labels Feb 21, 2023

zymap mentioned this pull request Feb 21, 2023

[fix] Recycle LongPairWrapper after use #3728

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Speed up the rebuildinding of RocksDB index #3458

Speed up the rebuildinding of RocksDB index #3458

merlimat commented Aug 26, 2022

StevenLuMT Aug 29, 2022

hangc0276 left a comment

hangc0276 commented Sep 5, 2022

eolivelli left a comment

StevenLuMT commented Sep 19, 2022

StevenLuMT left a comment

zymap commented Feb 21, 2023

Speed up the rebuildinding of RocksDB index #3458

Speed up the rebuildinding of RocksDB index #3458

Conversation

merlimat commented Aug 26, 2022

Motivation

StevenLuMT Aug 29, 2022

Choose a reason for hiding this comment

hangc0276 left a comment

Choose a reason for hiding this comment

hangc0276 commented Sep 5, 2022

eolivelli left a comment

Choose a reason for hiding this comment

StevenLuMT commented Sep 19, 2022

StevenLuMT left a comment

Choose a reason for hiding this comment

zymap commented Feb 21, 2023