Add new api resumeCompaction and suspendCompaction #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaozhangmin
force-pushed
the
compaction
branch
from
5d32cea
to
2efd7db
Compare
|
ci fail,have a look the error info |
dlg99
requested changes
Oct 4, 2022
There was a problem hiding this comment.
Great job.
We need to standardize naming for the API to not have two names for the same functionality.
Also needs documentation, see https://bookkeeper.apache.org/docs/admin/http
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
Outdated
Show resolved
Hide resolved
bookkeeper-http/http-server/src/main/java/org/apache/bookkeeper/http/HttpRouter.java
Outdated
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
compaction
branch
from
62bdf76
to
c07f653
Compare
|
@dlg99 PTAL again, thx |
|
api docs added |
|
rerun failure checks |
hangc0276
requested changes
Oct 17, 2022
bookkeeper-http/http-server/src/main/java/org/apache/bookkeeper/http/HttpRouter.java
Outdated
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
compaction
branch
from
09db963
to
3a4c407
Compare
…and suspend compaction through api
gaozhangmin
force-pushed
the
compaction
branch
from
9da6feb
to
4201ec7
Compare
gaozhangmin
requested review from
hangc0276 and
dlg99
and removed request for
dlg99 and
hangc0276
|
@hangc0276 PTAL again @dlg99 |
gaozhangmin
added a commit
to gaozhangmin/bookkeeper
that referenced
this pull request
Feb 23, 2023
…and suspend compaction through api (apache#3509) ### Motivation Compaction would bring high disk io util, It would better allowing to control suspending and resuming compaction through api ### Changes Add two apis to control resuming and suspending compaction. `/api/v1/bookie/gc/suspend_compaction` `/api/v1/bookie/gc/resume_compaction` (cherry picked from commit e169cbd)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…and suspend compaction through api (apache#3509) ### Motivation Compaction would bring high disk io util, It would better allowing to control suspending and resuming compaction through api ### Changes Add two apis to control resuming and suspending compaction. `/api/v1/bookie/gc/suspend_compaction` `/api/v1/bookie/gc/resume_compaction`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Compaction would bring high disk io util, It would better allowing to control suspending and resuming compaction through api
Changes
Add two apis to control resuming and suspending compaction.
/api/v1/bookie/gc/suspend_compaction/api/v1/bookie/gc/resume_compaction