Reduce unnecessary loop in removeIf if map is empty #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun failure checks |
shoothzj
approved these changes
Oct 4, 2022
zymap
approved these changes
Oct 8, 2022
zymap
pushed a commit
that referenced
this pull request
Oct 26, 2022
Reduce unnecessary loop in removeIf if section is empty (cherry picked from commit bc87bfb)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
Reduce unnecessary loop in removeIf if section is empty (cherry picked from commit bc87bfb)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
Reduce unnecessary loop in removeIf if section is empty (cherry picked from commit bc87bfb)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Reduce unnecessary loop in removeIf if section is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After unload all bundles of a heavy pulsar broker, cpu usage is still above 50%, here is a cpu profile and a heapdump
It looks like there's a schedule task executing
BookieClientImpl#monitorPendingOperations.Most of
completionObjectsinPerChannelBookieClientare empty.IMO, it's worth to check whether a section is empty or not in loop predication.
Changes
Add
size > 0intoSection#removeIfloop predication.