Skipping placementPolicyCheck when ledger replication disabled

[wenbingshen]

Motivation

When placementPolicyCheck is enabled and then bookkeeper shell autorecovery -disable is executed, placementPolicyCheck will detect ledgers that do not satisfy placementPolicy and write to zookeeper, but ReplicationWorker no longer obtains ledgers from zookeeper for replication work because autorecovery is disabled, which results in a large number of temporary nodes on zookeeper , when there are more ledgers that do not satisfy placementPolicy, the problem will get worse.

The method of ReplicationWorker to get ledger:

private boolean rereplicate() throws InterruptedException, BKException,
            UnavailableException {
        long ledgerIdToReplicate = underreplicationManager
                .getLedgerToRereplicate();
       
       ...

So we should also disable placementPolicyCheck.

[wenbingshen]

ping @zymap @dlg99 @eolivelli @hangc0276 @shoothzj PTAL. Thanks.

[dlg99]

This seems to be in line with the rest of Auditor's logic, looks like all the tasks scheduled by

            scheduleBookieCheckTask();
            scheduleCheckAllLedgersTask();
            schedulePlacementPolicyCheckTask();
            scheduleReplicasCheckTask();

won't do anything.

This brings another question: we also don't see what's going on in this case (independent of this change).
E.g. pausing AR for some time (maintenance window etc.) is fine but is it ok to not update counts of underreplicated ledgers?

[wenbingshen]

This brings another question: we also don't see what's going on in this case (independent of this change). E.g. pausing AR for some time (maintenance window etc.) is fine but is it ok to not update counts of underreplicated ledgers?

@dlg99 Good catch. Thanks for your review and comments. :)
AutoRecovery's responsibilities may need to be divided into the following departments:

Auditor: 1. Different ledger status detection.
2. and initiate ledger recovery tasks.
ReplicationWorker: Execute tasks triggered by Auditor.

maybe disable AutoRecovery needs to be divided into 2 parts:

1. Completely prohibit AutoRecovery work, including Auditor, ReplicationWorker
2. Only the replication work of AutoRecovery is prohibited, and the Auditor still performs the detection work and updates the relevant indicators.

This should be a new feature, we need other discussions and PRs.