Fix GetBookieInfo failed event stats #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
approved these changes
Nov 8, 2022
zymap
approved these changes
Nov 8, 2022
dlg99
approved these changes
Nov 8, 2022
hangc0276
pushed a commit
that referenced
this pull request
Nov 14, 2022
In `GetBookieInfoProcessorV3`, even if throw `IOException` and get DiskSpace failed, it will still `registerSuccessfulEvent`, which is wrong, we should `registerFailedEvent`. 1. registerFailedEvent when get DiskSpace failed. 2. add unit test. (cherry picked from commit 74e9ef4)
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jan 11, 2023
In `GetBookieInfoProcessorV3`, even if throw `IOException` and get DiskSpace failed, it will still `registerSuccessfulEvent`, which is wrong, we should `registerFailedEvent`. 1. registerFailedEvent when get DiskSpace failed. 2. add unit test. (cherry picked from commit 74e9ef4) (cherry picked from commit 31f548c)
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
### Motivation In `GetBookieInfoProcessorV3`, even if throw `IOException` and get DiskSpace failed, it will still `registerSuccessfulEvent`, which is wrong, we should `registerFailedEvent`. ### Changes 1. registerFailedEvent when get DiskSpace failed. 2. add unit test.
zymap
pushed a commit
that referenced
this pull request
Feb 16, 2023
### Motivation In `GetBookieInfoProcessorV3`, even if throw `IOException` and get DiskSpace failed, it will still `registerSuccessfulEvent`, which is wrong, we should `registerFailedEvent`. ### Changes 1. registerFailedEvent when get DiskSpace failed. 2. add unit test. (cherry picked from commit 74e9ef4)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation In `GetBookieInfoProcessorV3`, even if throw `IOException` and get DiskSpace failed, it will still `registerSuccessfulEvent`, which is wrong, we should `registerFailedEvent`. ### Changes 1. registerFailedEvent when get DiskSpace failed. 2. add unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In
GetBookieInfoProcessorV3, even if throwIOExceptionand get DiskSpace failed, it will stillregisterSuccessfulEvent, which is wrong, we shouldregisterFailedEvent.Changes