Add Http-service to check bookie sanity state #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
requested review from
merlimat,
hangc0276,
dlg99,
eolivelli and
nicoloboschi
eolivelli
requested changes
Nov 10, 2022
rdhabalia
force-pushed
the
sanity_http
branch
from
48f79f5
to
269d998
Compare
|
good point. made a change to run max (1) concurrent requests. |
|
@eolivelli can you PTAL. |
eolivelli
approved these changes
Nov 12, 2022
There was a problem hiding this comment.
I have left one minor issue please check my comment.
Then the patch is good to go from my POV.
And we should release this with 4.16.
@hangc0276 FYI
| try { | ||
| // allow max concurrent request as sanity-test check relatively | ||
| // longer time to complete | ||
| lock.acquire(); |
There was a problem hiding this comment.
Please wait at most for X seconds (5?) and if the semaphore cannot be acquired fail the request. We don't want many requests piling up.
Please also fix formatting
@eolivelli Sure |
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
### Motivation Right now, if Bookie startup or process fails due to various reasons then bookie getState() rest API still gives a successful response even though bookie writes are not going through. Therefore. Bookie should have a REST API to check bookie sanity test and that can be used to check bookie liveliness in k8/helm-chart or to plot bookie health graph. ### Changes Add Bookie REST API to check bookie health to validate bookie liveliness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, if Bookie startup or process fails due to various reasons then bookie getState() rest API still gives a successful response even though bookie writes are not going through. Therefore. Bookie should have a REST API to check bookie sanity test and that can be used to check bookie liveliness in k8/helm-chart or to plot bookie health graph.
Changes
Add Bookie REST API to check bookie health to validate bookie liveliness