Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include bkperf into bk all package #3632

Merged
merged 2 commits into from
Nov 12, 2022
Merged

Include bkperf into bk all package #3632

merged 2 commits into from
Nov 12, 2022

Conversation

hangc0276
Copy link
Contributor

Motivation

The bkperf dependency doesn't include in the bookkeeper-all package, and when we run bin/bkperf command, it will throw the following exceptions.

$ bin/bkperf journal append -j data -n 100000000 --sync true
Couldn't find module '(org.apache.bookkeeper-)?bookkeeper-perf' jar.
Do you want me to run `mvn package -DskipTests` for you ? (y|n)

Changes

Include the bookkeeper-perf dependency into bookkeeper-all package.

@hangc0276 hangc0276 self-assigned this Nov 12, 2022
@hangc0276 hangc0276 added dependencies Pull requests that update a dependency file release/4.14.6 release/4.15.4 labels Nov 12, 2022
@hangc0276 hangc0276 added this to the 4.16.0 milestone Nov 12, 2022
eolivelli
eolivelli approved these changes Nov 12, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eolivelli eolivelli merged commit a9d4082 into apache:master Nov 12, 2022
hangc0276 added a commit that referenced this pull request Nov 14, 2022
@hangc0276
Include bkperf into bk all package (#3632)
0966caf 
(cherry picked from commit a9d4082)
nicoloboschi pushed a commit to datastax/bookkeeper that referenced this pull request Jan 11, 2023
@hangc0276 @nicoloboschi
Include bkperf into bk all package (apache#3632)
aec9f31 
(cherry picked from commit a9d4082)
(cherry picked from commit 0966caf)
yaalsn pushed a commit to yaalsn/bookkeeper that referenced this pull request Jan 30, 2023
@hangc0276 @yaalsn
Include bkperf into bk all package (apache#3632)
c6d29f9
zymap pushed a commit that referenced this pull request Feb 16, 2023
@hangc0276 @zymap
Include bkperf into bk all package (#3632)
ba47374 
(cherry picked from commit a9d4082)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@hangc0276
Include bkperf into bk all package (apache#3632)
06f6114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@dlg99 dlg99 Awaiting requested review from dlg99

@shoothzj shoothzj Awaiting requested review from shoothzj

@StevenLuMT StevenLuMT Awaiting requested review from StevenLuMT

@zymap zymap Awaiting requested review from zymap

Assignees

@hangc0276 hangc0276

Labels
cherry-picked/branch-4.14 cherry-picked/branch-4.15 dependencies Pull requests that update a dependency file release/4.14.6 release/4.15.4
Projects
None yet
Milestone
4.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hangc0276 @eolivelli @zymap