Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] [server] Refactor ByteBuf release method in module distributedlog-core #3691

Merged
merged 1 commit into from Dec 6, 2022
Merged

[refactor] [server] Refactor ByteBuf release method in module distributedlog-core #3691

merged 1 commit into from Dec 6, 2022

Conversation

StevenLuMT
Copy link
Contributor

Motivation

It may throw an exception when release a ByteBuf object. so the exception in ByteBuf.release should be checked.

Changes

  1. Use ReferenceCountUtil.safeRelease() instead of ByteBuf.release() in module distributedlog-core

HQebupt
HQebupt approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@HQebupt HQebupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StevenLuMT StevenLuMT mentioned this pull request Dec 4, 2022
Open
9 tasks
horizonzy
horizonzy approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@StevenLuMT StevenLuMT merged commit 7ae5a04 into apache:master Dec 6, 2022
@StevenLuMT StevenLuMT added this to the 4.16.0 milestone Dec 6, 2022
hangc0276 pushed a commit that referenced this pull request Dec 8, 2022
@StevenLuMT @hangc0276
module distributedlog-core: refactor ByteBuf release usage (#3691)
eaf3996 
Co-authored-by: lushiji <lushiji@didiglobal.com>
(cherry picked from commit 7ae5a04)
nicoloboschi pushed a commit to datastax/bookkeeper that referenced this pull request Jan 11, 2023
@StevenLuMT @nicoloboschi
module distributedlog-core: refactor ByteBuf release usage (apache#3691)
40348d7 
Co-authored-by: lushiji <lushiji@didiglobal.com>
(cherry picked from commit 7ae5a04)
(cherry picked from commit eaf3996)
yaalsn pushed a commit to yaalsn/bookkeeper that referenced this pull request Jan 30, 2023
@StevenLuMT @yaalsn
module distributedlog-core: refactor ByteBuf release usage (apache#3691)
aea06a6 
Co-authored-by: lushiji <lushiji@didiglobal.com>
@hangc0276 hangc0276 mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HQebupt HQebupt HQebupt approved these changes

@hangc0276 hangc0276 hangc0276 approved these changes

@horizonzy horizonzy horizonzy approved these changes

@zymap zymap zymap approved these changes

@dlg99 dlg99 Awaiting requested review from dlg99

@eolivelli eolivelli Awaiting requested review from eolivelli

@nicoloboschi nicoloboschi Awaiting requested review from nicoloboschi

Assignees

@StevenLuMT StevenLuMT

Labels
area/bookie cherry-picked/branch-4.14 release/4.14.6 type/bug
Projects
None yet
Milestone
4.16.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@StevenLuMT @HQebupt @hangc0276 @horizonzy @zymap