[feature] Added api/v1/bookie/cluster_info REST API #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlg99
force-pushed
the
rest-cluster-info
branch
from
6be2213
to
4f9e1f0
Compare
|
rerun failure checks |
eolivelli
requested changes
Dec 22, 2022
There was a problem hiding this comment.
very useful !
in BKVM we had to call many internal BookKeeperAdmin APIs to get these pieces of information
@nicoloboschi @mino181295 @aluccaroni @dianacle you may be interested
| @@ -256,10 +260,19 @@ public static LifecycleComponent buildStorageServer(CompositeConfiguration conf, | |||
|
|
|||
| // Build http service | |||
| if (bkServerConf.isHttpServerEnabled()) { | |||
| MetadataBookieDriver metadataDriver = BookieResources.createMetadataDriver(bkServerConf, | |||
There was a problem hiding this comment.
are we going to create an additional connection to ZooKeeper ?
There was a problem hiding this comment.
AFAICT, there is an internal cache in MetadataDrivers so if there is one already it will be reused
nicoloboschi
approved these changes
Dec 22, 2022
|
@StevenLuMT dead link checker failure is fixed at #3712 |
dlg99
added a commit
to dlg99/bookkeeper
that referenced
this pull request
Dec 23, 2022
Descriptions of the changes in this PR:
Information provided by current REST API is not enough (and cumbersome to combine) to answer such question as "is any data in danger if I shut down one more bookie".
E.g. getting list of underreplicated ledgers can get some info but it is either fast (no ledgers) or can be super slow on large cluster with some bookies lost (it retrieves full list of ledgers).
Even if there are no UR ledgers it still possible that the problem is that Auditor is down etc.
Added api/v1/bookie/cluster_info REST API
```
curl -s 127.0.0.1:8080/api/v1/bookie/cluster_info
{
"auditorElected" : false,
"auditorId" : "",
"clusterUnderReplicated" : false,
"ledgerReplicationEnabled" : true,
"totalBookiesCount" : 1,
"writableBookiesCount" : 1,
"readonlyBookiesCount" : 0,
"unavailableBookiesCount" : 0
}%
```
Side-fix:
`org.apache.bookkeeper.stream.cluster.StandaloneStarter` (used by bookie standalone) did not pass `LedgerManagerFactory` to the http server thus REST calls that needed it didn't work.
Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com>
This closes apache#3710 from dlg99/rest-cluster-info
(cherry picked from commit 032aef7)
dlg99
added a commit
to dlg99/bookkeeper
that referenced
this pull request
Dec 23, 2022
Descriptions of the changes in this PR:
Information provided by current REST API is not enough (and cumbersome to combine) to answer such question as "is any data in danger if I shut down one more bookie".
E.g. getting list of underreplicated ledgers can get some info but it is either fast (no ledgers) or can be super slow on large cluster with some bookies lost (it retrieves full list of ledgers).
Even if there are no UR ledgers it still possible that the problem is that Auditor is down etc.
Added api/v1/bookie/cluster_info REST API
```
curl -s 127.0.0.1:8080/api/v1/bookie/cluster_info
{
"auditorElected" : false,
"auditorId" : "",
"clusterUnderReplicated" : false,
"ledgerReplicationEnabled" : true,
"totalBookiesCount" : 1,
"writableBookiesCount" : 1,
"readonlyBookiesCount" : 0,
"unavailableBookiesCount" : 0
}%
```
Side-fix:
`org.apache.bookkeeper.stream.cluster.StandaloneStarter` (used by bookie standalone) did not pass `LedgerManagerFactory` to the http server thus REST calls that needed it didn't work.
Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com>
This closes apache#3710 from dlg99/rest-cluster-info
(cherry picked from commit 032aef7)
dlg99
added a commit
to dlg99/bookkeeper
that referenced
this pull request
Dec 23, 2022
Descriptions of the changes in this PR:
Information provided by current REST API is not enough (and cumbersome to combine) to answer such question as "is any data in danger if I shut down one more bookie".
E.g. getting list of underreplicated ledgers can get some info but it is either fast (no ledgers) or can be super slow on large cluster with some bookies lost (it retrieves full list of ledgers).
Even if there are no UR ledgers it still possible that the problem is that Auditor is down etc.
Added api/v1/bookie/cluster_info REST API
```
curl -s 127.0.0.1:8080/api/v1/bookie/cluster_info
{
"auditorElected" : false,
"auditorId" : "",
"clusterUnderReplicated" : false,
"ledgerReplicationEnabled" : true,
"totalBookiesCount" : 1,
"writableBookiesCount" : 1,
"readonlyBookiesCount" : 0,
"unavailableBookiesCount" : 0
}%
```
Side-fix:
`org.apache.bookkeeper.stream.cluster.StandaloneStarter` (used by bookie standalone) did not pass `LedgerManagerFactory` to the http server thus REST calls that needed it didn't work.
Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com>
This closes apache#3710 from dlg99/rest-cluster-info
(cherry picked from commit 032aef7)
dlg99
added a commit
that referenced
this pull request
Dec 27, 2022
Descriptions of the changes in this PR:
Information provided by current REST API is not enough (and cumbersome to combine) to answer such question as "is any data in danger if I shut down one more bookie".
E.g. getting list of underreplicated ledgers can get some info but it is either fast (no ledgers) or can be super slow on large cluster with some bookies lost (it retrieves full list of ledgers).
Even if there are no UR ledgers it still possible that the problem is that Auditor is down etc.
Added api/v1/bookie/cluster_info REST API
```
curl -s 127.0.0.1:8080/api/v1/bookie/cluster_info
{
"auditorElected" : false,
"auditorId" : "",
"clusterUnderReplicated" : false,
"ledgerReplicationEnabled" : true,
"totalBookiesCount" : 1,
"writableBookiesCount" : 1,
"readonlyBookiesCount" : 0,
"unavailableBookiesCount" : 0
}%
```
Side-fix:
`org.apache.bookkeeper.stream.cluster.StandaloneStarter` (used by bookie standalone) did not pass `LedgerManagerFactory` to the http server thus REST calls that needed it didn't work.
Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com>
This closes #3710 from dlg99/rest-cluster-info
(cherry picked from commit 032aef7)
dlg99
added a commit
that referenced
this pull request
Dec 27, 2022
Descriptions of the changes in this PR:
Information provided by current REST API is not enough (and cumbersome to combine) to answer such question as "is any data in danger if I shut down one more bookie".
E.g. getting list of underreplicated ledgers can get some info but it is either fast (no ledgers) or can be super slow on large cluster with some bookies lost (it retrieves full list of ledgers).
Even if there are no UR ledgers it still possible that the problem is that Auditor is down etc.
Added api/v1/bookie/cluster_info REST API
```
curl -s 127.0.0.1:8080/api/v1/bookie/cluster_info
{
"auditorElected" : false,
"auditorId" : "",
"clusterUnderReplicated" : false,
"ledgerReplicationEnabled" : true,
"totalBookiesCount" : 1,
"writableBookiesCount" : 1,
"readonlyBookiesCount" : 0,
"unavailableBookiesCount" : 0
}%
```
Side-fix:
`org.apache.bookkeeper.stream.cluster.StandaloneStarter` (used by bookie standalone) did not pass `LedgerManagerFactory` to the http server thus REST calls that needed it didn't work.
Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com>
This closes #3710 from dlg99/rest-cluster-info
(cherry picked from commit 032aef7)
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
Descriptions of the changes in this PR:
### Motivation
Information provided by current REST API is not enough (and cumbersome to combine) to answer such question as "is any data in danger if I shut down one more bookie".
E.g. getting list of underreplicated ledgers can get some info but it is either fast (no ledgers) or can be super slow on large cluster with some bookies lost (it retrieves full list of ledgers).
Even if there are no UR ledgers it still possible that the problem is that Auditor is down etc.
### Changes
Added api/v1/bookie/cluster_info REST API
```
curl -s 127.0.0.1:8080/api/v1/bookie/cluster_info
{
"auditorElected" : false,
"auditorId" : "",
"clusterUnderReplicated" : false,
"ledgerReplicationEnabled" : true,
"totalBookiesCount" : 1,
"writableBookiesCount" : 1,
"readonlyBookiesCount" : 0,
"unavailableBookiesCount" : 0
}%
```
Side-fix:
`org.apache.bookkeeper.stream.cluster.StandaloneStarter` (used by bookie standalone) did not pass `LedgerManagerFactory` to the http server thus REST calls that needed it didn't work.
Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com>
This closes apache#3710 from dlg99/rest-cluster-info
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Descriptions of the changes in this PR:
### Motivation
Information provided by current REST API is not enough (and cumbersome to combine) to answer such question as "is any data in danger if I shut down one more bookie".
E.g. getting list of underreplicated ledgers can get some info but it is either fast (no ledgers) or can be super slow on large cluster with some bookies lost (it retrieves full list of ledgers).
Even if there are no UR ledgers it still possible that the problem is that Auditor is down etc.
### Changes
Added api/v1/bookie/cluster_info REST API
```
curl -s 127.0.0.1:8080/api/v1/bookie/cluster_info
{
"auditorElected" : false,
"auditorId" : "",
"clusterUnderReplicated" : false,
"ledgerReplicationEnabled" : true,
"totalBookiesCount" : 1,
"writableBookiesCount" : 1,
"readonlyBookiesCount" : 0,
"unavailableBookiesCount" : 0
}%
```
Side-fix:
`org.apache.bookkeeper.stream.cluster.StandaloneStarter` (used by bookie standalone) did not pass `LedgerManagerFactory` to the http server thus REST calls that needed it didn't work.
Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com>
This closes apache#3710 from dlg99/rest-cluster-info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Information provided by current REST API is not enough (and cumbersome to combine) to answer such question as "is any data in danger if I shut down one more bookie".
E.g. getting list of underreplicated ledgers can get some info but it is either fast (no ledgers) or can be super slow on large cluster with some bookies lost (it retrieves full list of ledgers).
Even if there are no UR ledgers it still possible that the problem is that Auditor is down etc.
Changes
Added api/v1/bookie/cluster_info REST API
Side-fix:
org.apache.bookkeeper.stream.cluster.StandaloneStarter(used by bookie standalone) did not passLedgerManagerFactoryto the http server thus REST calls that needed it didn't work.