[improve] Optimize masterKeyCache StorageNotificationListener #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StevenLuMT @eolivelli PTAL. Thanks. |
|
rerun failure checks |
1 similar comment
|
rerun failure checks |
eolivelli
approved these changes
Jan 13, 2023
hangc0276
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to PR #3522, in order to implement masterKeyCache to clean up the deleted ledgerId, PR #3522 introduced LedgerStorageNotificationListener, which is used to monitor the cleanup action of calling back masterKeyCache when the ledger is deleted. I noticed that before this, LedgerStorage already has The purpose of the implementation of LedgerDeletionListener is to call back the corresponding user to do some cleaning operations after the ledger is deleted, which fully meets the requirements of LedgerStorageNotificationListener.
The function of the additionally introduced LedgerStorageNotificationListener is the same as that of LedgerDeletionListener, but a strange operation L is introduced in the GC thread: the GC thread needs to process a LedgerStorageNotificationListener notification, and the GC thread calls ledgerStorage.deleteLedger(ledgerId), and it will be executed LedgerDeletionListener notification again during the processing deleteLedger.
Changes
Replace LedgerStorageNotificationListener with existing LedgerDeletionListener to achieve this requirement.