[bookie] Fix memory leak when the Bookie is in read only mode #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horizonzy
force-pushed
the
fix-memory-leak-when-read-only
branch
from
3eb33bb
to
4576422
Compare
wenbingshen
reviewed
Jan 18, 2023
Comment on lines
+178
to
181
| if (request instanceof BookieProtocol.ParsedAddRequest) { | ||
| ((BookieProtocol.ParsedAddRequest) request).release(); | ||
| request.recycle(); | ||
| requestProcessor.onAddRequestFinish(); |
There was a problem hiding this comment.
Can the release of ParsedAddRequest be executed in the recycle method? It seems that these two methods are always used together, and there is a forced switch here, which seems a bit awkward.
You can look at org.apache.bookkeeper.proto.BookieProtocol.AddRequest#recycle method
@Override
public void recycle() {
ledgerId = -1;
entryId = -1;
masterKey = null;
ReferenceCountUtil.safeRelease(data);
data = null;
recyclerHandle.recycle(this);
}There was a problem hiding this comment.
It can't, we shouldn't release the data in the recycle.
In the normal case, it will recycle the request, but the data is already free.
See:
There was a problem hiding this comment.
I saw it, sorry I misread it earlier. Nice work. Thanks.
wenbingshen
approved these changes
Jan 18, 2023
|
@merlimat @eolivelli @dlg99 @zymap Please help take a look at this PR, thanks. |
zymap
approved these changes
Feb 7, 2023
eolivelli
changed the title
dlg99
approved these changes
Feb 7, 2023
hangc0276
pushed a commit
that referenced
this pull request
Feb 8, 2023
zymap
pushed a commit
that referenced
this pull request
Feb 16, 2023
gaozhangmin
pushed a commit
to gaozhangmin/bookkeeper
that referenced
this pull request
Feb 23, 2023
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Mar 13, 2023
Descriptions of the changes in this PR: Fixes apache#3745 (cherry picked from commit af82d14) (cherry picked from commit 9e0e198)
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Mar 13, 2023
Descriptions of the changes in this PR: Fixes apache#3745 (cherry picked from commit af82d14) (cherry picked from commit 9e0e198)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Fixes #3745