Fix QueueEntry recycle problem. #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
approved these changes
Jan 18, 2023
lhotari
reviewed
Feb 3, 2023
| callbackTime.addLatency(MathUtils.elapsedNanos(startTime), TimeUnit.NANOSECONDS); | ||
| recycle(); |
There was a problem hiding this comment.
@horizonzy This change wasn't mentioned in the PR description. Why was this missing before? Was the recycling completely unused before? /cc @hangc0276
There was a problem hiding this comment.
Cause we already reset callbackTime to null. And we should ensure do all works before recycle self, instead of addLatency after recycle self.
hangc0276
pushed a commit
that referenced
this pull request
Feb 8, 2023
Descriptions of the changes in this PR: In the QueueEntry recycle, it only recycles itself to the object pool, but didn't reset some properties. Like entry, cb, etc. We should reset the filed before recycles itself. (cherry picked from commit 901f76c)
zymap
pushed a commit
that referenced
this pull request
Feb 16, 2023
Descriptions of the changes in this PR: In the QueueEntry recycle, it only recycles itself to the object pool, but didn't reset some properties. Like entry, cb, etc. We should reset the filed before recycles itself. (cherry picked from commit 901f76c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
In the QueueEntry recycle, it only recycles itself to the object pool, but didn't reset some properties.
Like entry, cb, etc. We should reset the filed before recycles itself.