Execute clean indexes in finally

[gaozhangmin]

Motivation

Fixes #3771

Changes

Move cleanupExecutor to finally block to make sure it can be executed every checkpoint process.

[codecov-commenter]

Codecov Report

Merging #3772 (c65b06d) into master (b85ac48) will decrease coverage by 20.65%.
The diff coverage is 55.55%.

@@              Coverage Diff              @@
##             master    #3772       +/-   ##
=============================================
- Coverage     68.07%   47.43%   -20.65%     
+ Complexity     6648     4508     -2140     
=============================================
  Files           467      467               
  Lines         40829    40829               
  Branches       5234     5234               
=============================================
- Hits          27795    19366     -8429     
- Misses        10772    19467     +8695     
+ Partials       2262     1996      -266     

Flag	Coverage Δ
bookie	?
client	?
remaining	29.41% <0.00%> (-0.05%)	⬇️
replication	41.42% <55.55%> (+0.03%)	⬆️
tls	21.09% <0.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ie/storage/ldb/SingleDirectoryDbLedgerStorage.java	23.51% <55.55%> (-44.08%)	⬇️
...java/org/apache/bookkeeper/proto/BookieClient.java	0.00% <0.00%> (-100.00%)	⬇️
...a/org/apache/bookkeeper/client/api/BookKeeper.java	0.00% <0.00%> (-100.00%)	⬇️
...org/apache/bookkeeper/bookie/ReadOnlyFileInfo.java	0.00% <0.00%> (-100.00%)	⬇️
...org/apache/bookkeeper/bookie/datainteg/Events.java	0.00% <0.00%> (-100.00%)	⬇️
...rg/apache/bookkeeper/client/api/CreateBuilder.java	0.00% <0.00%> (-100.00%)	⬇️
.../apache/bookkeeper/bookie/storage/EntryLogger.java	0.00% <0.00%> (-100.00%)	⬇️
.../bookkeeper/proto/checksum/DummyDigestManager.java	0.00% <0.00%> (-100.00%)	⬇️
...okkeeper/client/BookieAddressResolverDisabled.java	0.00% <0.00%> (-100.00%)	⬇️
...keeper/proto/ReadLastConfirmedAndEntryContext.java	0.00% <0.00%> (-100.00%)	⬇️
... and 226 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[hangc0276]

What's the difference between moving the code block into finally?

[StevenLuMT]

I think it doesn't solve the fundamental problem.

[gaozhangmin]

What's the difference between moving the code block into finally?

Moved to finally, The index clean up is going on when writeCache.isEmpty().
Which can address the issue i mentioned in #3771, When a bookie transits from readonly to write-read mode. lots of index cleanup would gather @hangc0276 @StevenLuMT

[gaozhangmin]

@hangc0276 PTAL

[StevenLuMT]

lgtm