Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branch-4.15] Use ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease() #3797

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -984,9 +984,9 @@ public void setExplicitLac(ByteBuf entry, WriteCallback writeCallback, Object ct
stateManager.transitionToReadOnlyMode();
throw new IOException(e);
} finally {
ReferenceCountUtil.safeRelease(entry);
ReferenceCountUtil.release(entry);
if (explicitLACEntry != null) {
ReferenceCountUtil.safeRelease(explicitLACEntry);
ReferenceCountUtil.release(explicitLACEntry);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public synchronized void close() throws IOException {
if (closed) {
return;
}
ReferenceCountUtil.safeRelease(writeBuffer);
ReferenceCountUtil.release(writeBuffer);
fileChannel.close();
closed = true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ public void recycle() {
ledgerId = -1;
entryId = -1;
masterKey = null;
ReferenceCountUtil.safeRelease(data);
ReferenceCountUtil.release(data);
data = null;
recyclerHandle.recycle(this);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)
ctx.write(bx.retainedDuplicate(), i == (buffersCount - 1) ? promise : ctx.voidPromise());
}
} finally {
ReferenceCountUtil.safeRelease(b);
ReferenceCountUtil.release(b);
}
} else {
ctx.write(msg, promise);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -303,25 +303,25 @@ public ChannelFuture deregister(ChannelPromise promise) {

@Override
public ChannelFuture write(Object msg) {
ReferenceCountUtil.safeRelease(msg);
ReferenceCountUtil.release(msg);
return null;
}

@Override
public ChannelFuture write(Object msg, ChannelPromise promise) {
ReferenceCountUtil.safeRelease(msg);
ReferenceCountUtil.release(msg);
return null;
}

@Override
public ChannelFuture writeAndFlush(Object msg, ChannelPromise promise) {
ReferenceCountUtil.safeRelease(msg);
ReferenceCountUtil.release(msg);
return null;
}

@Override
public ChannelFuture writeAndFlush(Object msg) {
ReferenceCountUtil.safeRelease(msg);
ReferenceCountUtil.release(msg);
return null;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ private void readEntriesFromReadAheadCache(PendingReadRequest nextRequest) {
return;
}
} finally {
ReferenceCountUtil.safeRelease(removedEntry);
ReferenceCountUtil.release(removedEntry);
}
} else if (skipBrokenEntries && BKException.Code.DigestMatchException == entry.getRc()) {
// skip this entry and move forward
Expand Down