Add trigger entry location index rocksDB compact REST API #3802

Nicklee007 · 2023-02-23T12:08:36Z

Motivation

After the bookie instance running long time, the bookie entry location index rocksDB .sst file size maybe expand to 20-30GB as one ledger data dir's location index in some case, which will cause the rocksDB scan operator cost more time and cause the bookie client request timeout.

Add trigger entry location index rocksDB compact REST API which can trigger entry location rocksDB compaction and get the compaction status.

The full range entry location index rocksDB compact will cause the entry location index dir express higher IOUtils. So we'd better trigger the entry location rocksDB compact by the api in low data flow period.

Some case before rocksDB compact:

After rocksDB compact:

Changes

Add REST API to trigger entry location index rocksDB compact.

codecov-commenter · 2023-02-23T12:30:57Z

Codecov Report

Merging #3802 (75f6fb8) into master (d6748f9) will decrease coverage by 0.04%.
The diff coverage is 41.98%.

@@             Coverage Diff              @@
##             master    #3802      +/-   ##
============================================
- Coverage     60.40%   60.36%   -0.04%     
- Complexity     5862     5880      +18     
============================================
  Files           473      474       +1     
  Lines         40960    41112     +152     
  Branches       5240     5256      +16     
============================================
+ Hits          24740    24817      +77     
- Misses        14002    14080      +78     
+ Partials       2218     2215       -3

Flag	Coverage Δ
bookie	`39.73% <3.81%> (-0.04%)`	⬇️
remaining	`29.52% <0.00%> (-0.10%)`	⬇️
replication	`41.26% <39.69%> (-0.09%)`	⬇️
tls	`20.93% <0.00%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...bookkeeper/bookie/storage/ldb/DbLedgerStorage.java	`67.43% <0.00%> (-7.19%)`	⬇️
...kkeeper/bookie/storage/ldb/EntryLocationIndex.java	`73.52% <0.00%> (-4.60%)`	⬇️
...bookkeeper/bookie/storage/ldb/KeyValueStorage.java	`0.00% <0.00%> (ø)`
...ie/storage/ldb/SingleDirectoryDbLedgerStorage.java	`63.91% <0.00%> (-1.25%)`	⬇️
...per/bookie/storage/ldb/KeyValueStorageRocksDB.java	`65.71% <17.85%> (-5.61%)`	⬇️
...er/http/service/TriggerLocationCompactService.java	`78.94% <78.94%> (ø)`
...va/org/apache/bookkeeper/bookie/LedgerStorage.java	`55.55% <80.00%> (+5.55%)`	⬆️
.../bookkeeper/server/http/BKHttpServiceProvider.java	`68.35% <100.00%> (+0.40%)`	⬆️

... and 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dlg99

Awesome contribution!

...er-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java

eolivelli

+1

nicoloboschi

Good work!
Could you please update the doc as well ?
https://github.com/apache/bookkeeper/blob/591ceb971a7eda7ce5252f88c5cf694f3f4c30b2/site3/website/docs/admin/http.md

...r/src/main/java/org/apache/bookkeeper/server/http/service/TriggerLocationCompactService.java

Nicklee007 · 2023-02-27T02:12:25Z

rerun failure checks

hangc0276

After we triggered the compaction, it will have a huge performance impact on the ledger disk IO. I wonder if we can introduce a REST API to stop it.

...r/src/main/java/org/apache/bookkeeper/server/http/service/TriggerLocationCompactService.java

bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java

...keeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java

...r/src/main/java/org/apache/bookkeeper/server/http/service/TriggerLocationCompactService.java

bookkeeper-server/src/test/java/org/apache/bookkeeper/server/http/TestHttpService.java

hangc0276 · 2023-02-27T11:00:07Z

@Nicklee007 Please rebase the master, thanks.

Nicklee007 · 2023-03-07T09:35:02Z

After we triggered the compaction, it will have a huge performance impact on the ledger disk IO. I wonder if we can introduce a REST API to stop it.

Maybe we can add another REST API to stop it.

...r/src/main/java/org/apache/bookkeeper/server/http/service/TriggerLocationCompactService.java

...er-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java

...r/src/main/java/org/apache/bookkeeper/server/http/service/TriggerLocationCompactService.java

horizonzy

LGTM.

Nicklee007 · 2023-03-14T16:04:26Z

rerun failure checks

* Fix memory leak issue of reading small entries (apache#3844) * Make read entry request recyclable (apache#3842) * Make read entry request recyclable * Move recycle to finally block * Fix test and comments * Fix test * Avoid unnecessary force write. (apache#3847) * Avoid unnecessary force write. * code clean. * fix style * Correct the running job name for the test group (apache#3851) --- ### Motivation The running tests job name doesn't match the tests. Correct the job name. * add timeout for two flaky timeout tests (apache#3855) * add V2 protocal and warmupMessages support for benchMark (apache#3856) * disable trimStackTrack for code-coverage profile (apache#3854) * Fix bkperf log directory not found (apache#3858) ### Motivation When using the bkperf command `bin/bkperf journal append -j data -n 100000000 --sync true` to test the BookKeeper journal performance, it failed with the following exception ``` [0.002s][error][logging] Error opening log file '/Users/hangc/Downloads/tmp/tc/batch/ta/bookkeeper-all-4.16.0-SNAPSHOT/logs/bkperf-gc.log': No such file or directory [0.002s][error][logging] Initialization of output 'file=/Users/hangc/Downloads/tmp/tc/batch/ta/bookkeeper-all-4.16.0-SNAPSHOT/logs/bkperf-gc.log' using options 'filecount=5,filesize=64m' failed. Invalid -Xlog option '-Xlog:gc=info:file=/Users/hangc/Downloads/tmp/tc/batch/ta/bookkeeper-all-4.16.0-SNAPSHOT/logs/bkperf-gc.log::filecount=5,filesize=64m', see error log for details. Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. ``` The root cause is that the `logs` directory was not created. ### Modifications Create the `logs` directory before bkperf started. * [improve] Fix indexDirs upgrade failed (apache#3762) * fix indexDirs upgrade failed * Bump checkstyle-plugin from 3.1.2 to 3.2.1 (apache#3850) * [Flaky] Fix flaky test in testRaceGuavaEvictAndReleaseBeforeRetain (apache#3857) * Fix flaky test in testRaceGuavaEvictAndReleaseBeforeRetain * format code * Fix NPE in BenchThroughputLatency (apache#3859) * Update website to 4.15.4 (apache#3862) --- ### Motivation Update website to 4.15.4 * change rocksDB config level_compaction_dynamic_level_bytes to CFOptions (apache#3860) ### Motivation After PR apache#3056 , Bookkeeper set `level_compaction_dynamic_level_bytes=true` as `TableOptions` in `entry_location_rocksdb.conf.default` , which will cause `level_compaction_dynamic_level_bytes` lose efficacy and will cause rocksDB .sst file compact sort chaos when update bookie release. As RocksDB conf, `level_compaction_dynamic_level_bytes` need set as `CFOptions` https://github.com/facebook/rocksdb/blob/master/examples/rocksdb_option_file_example.ini <img width="703" alt="image" src="https://user-images.githubusercontent.com/84127069/224640399-d5481fe5-7b75-4229-ac06-3d280aa9ae6d.png"> <img width="240" alt="image" src="https://user-images.githubusercontent.com/84127069/224640621-737d0a42-4e01-4f38-bd5a-862a93bc4b32.png"> ### Changes 1. Change `level_compaction_dynamic_level_bytes=true` from `TableOptions` to `CFOptions` in `entry_location_rocksdb.conf.default` ; * Correct the running job flag for the test group. (apache#3865) * Release note for 4.15.4 (apache#3831) --- ### Motivation Release note for 4.15.4 * Add trigger entry location index rocksDB compact interface. (apache#3802) ### Motivation After the bookie instance running long time, the bookie entry location index rocksDB `.sst` file size maybe expand to 20-30GB as one ledger data dir's location index in some case, which will cause the rocksDB scan operator cost more time and cause the bookie client request timeout. Add trigger entry location index rocksDB compact REST API which can trigger entry location rocksDB compaction and get the compaction status. The full range entry location index rocksDB compact will cause the entry location index dir express higher IOUtils. So we'd better trigger the entry location rocksDB compact by the api in low data flow period. **Some case before rocksDB compact:** <img width="232" alt="image" src="https://user-images.githubusercontent.com/84127069/220893469-e6fbc1a3-c767-4ffe-8ae9-f05ad1833c50.png"> <img width="288" alt="image" src="https://user-images.githubusercontent.com/84127069/220891359-dc37e139-37b0-461b-8001-dcc48517366c.png"> **After rocksDB compact:** <img width="255" alt="image" src="https://user-images.githubusercontent.com/84127069/220891419-24267fa7-348c-4fbd-8b3e-70a99840bce5.png"> ### Changes 1. Add REST API to trigger entry location index rocksDB compact. * Pick the higher leak detection level between netty and bookkeeper. (apache#3794) ### Motivation 1. Pick the higher leak detection level between netty and bookkeeper. 2. Enhance the bookkeeper leak detection value match rule, now it's case insensitive. There are detailed information about it: https://lists.apache.org/thread/d3zw8bxhlg0wxfhocyjglq0nbxrww3sg * Disable code coverage and codecov report (apache#3863) ### Motivation There're two reasons that we want to disable the code coverage. 1. The current report result is not accurate. 2. We can't get the PR's unit test's code coverage because of the apache Codecov permission. * Add small files check in garbage collection (apache#3631) ### Motivation When we use `TransactionalEntryLogCompactor` to compact the entry log files, it will generate a lot of small entry log files, and for those files, the file usage is usually greater than 90%, which can not be compacted unless the file usage decreased. ![image](https://user-images.githubusercontent.com/5436568/201135615-4d6072f5-e353-483d-9afb-48fad8134044.png) ### Changes We introduce the entry log file size check during compaction, and the checker is controlled by `gcEntryLogSizeRatio`. If the total entry log file size is less than `gcEntryLogSizeRatio * logSizeLimit`, the entry log file will be compacted even though the file usage is greater than 90%. This feature is disabled by default and the `gcEntryLogSizeRatio` default value is `0.0` * [improvement] Delay all audit task when have a already delayed bookie check task (apache#3818) ### Motivation Fixes apache#3817 For details, see: apache#3817 ### Changes When there is an `auditTask` during the `lostBookieRecoveryDelay` delay, other detection tasks should be skipped. * Change order of doGcLedgers and extractMetaFromEntryLogs (apache#3869) * [Bugfix] make metadataDriver initialization more robust (apache#3873) Co-authored-by: zengqiang.xu <zengqiang.xu@shopee.com> * Enable CI for the streamstorage python client (apache#3875) * Fix compaction threshold default value precision problem. (apache#3871) * Fix compaction threshold precision problem. * Fix compaction threshold precision problem. * Single buffer for small add requests (apache#3783) * Single buffer for small add requests * Fixed checkstyle * Fixed treating of ComposityByteBuf * Fixed merge issues * Fixed merge issues * WIP * Fixed test and removed dead code * Removed unused import * Fixed BookieJournalTest * removed unused import * fix the checkstyle * fix failed test * fix failed test --------- Co-authored-by: chenhang <chenhang@apache.org> * Add log for entry log file delete. (apache#3872) * Add log for entry log file delete. * add log info. * Address the comment. * Address the comment. * revert the code. * Improve group and flush add-responses after journal sync (apache#3848) Descriptions of the changes in this PR: This is an improvement for apache#3837 ### Motivation 1. Now if the maxPendingResponsesSize is expanded large, it will not decrease. => We should make it flexible. 2. Now after prepareSendResponseV2 to the channel, then we trigger all channels to flush pendingSendResponses, maybe there is only a few channels that need to flush, but if we trigger all channels, it's a waste. => We only flush the channel which prepareSendResponseV2. --------- Co-authored-by: Penghui Li <penghui@apache.org> Co-authored-by: Yong Zhang <zhangyong1025.zy@gmail.com> Co-authored-by: Hang Chen <chenhang@apache.org> Co-authored-by: wenbingshen <oliver.shen999@gmail.com> Co-authored-by: ZhangJian He <shoothzj@gmail.com> Co-authored-by: lixinyang <84127069+Nicklee007@users.noreply.github.com> Co-authored-by: YANGLiiN <ielin@qq.com> Co-authored-by: Lishen Yao <yaalsn@gmail.com> Co-authored-by: Andrey Yegorov <8622884+dlg99@users.noreply.github.com> Co-authored-by: ZanderXu <zanderxu@apache.org> Co-authored-by: zengqiang.xu <zengqiang.xu@shopee.com> Co-authored-by: Matteo Merli <mmerli@apache.org>

dlg99 approved these changes Feb 23, 2023

View reviewed changes

...er-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java Outdated Show resolved Hide resolved

eolivelli approved these changes Feb 23, 2023

View reviewed changes

dlg99 mentioned this pull request Feb 23, 2023

GarbageCollectorThread should periodically trigger compaction of RocksDB-backed EntryLogMetadataMap #3803

Open

nicoloboschi requested changes Feb 23, 2023

View reviewed changes

...r/src/main/java/org/apache/bookkeeper/server/http/service/TriggerLocationCompactService.java Outdated Show resolved Hide resolved

...r/src/main/java/org/apache/bookkeeper/server/http/service/TriggerLocationCompactService.java Show resolved Hide resolved

Nicklee007 force-pushed the rocksdb-compact branch 4 times, most recently from f1e474d to 13f5f67 Compare February 24, 2023 07:40

nicoloboschi approved these changes Feb 24, 2023

View reviewed changes

hangc0276 requested changes Feb 27, 2023

View reviewed changes

hangc0276 assigned Nicklee007 Feb 27, 2023

hangc0276 added this to the 4.17.0 milestone Feb 27, 2023

hangc0276 added the type/feature label Feb 27, 2023

Nicklee007 force-pushed the rocksdb-compact branch from 7c1de85 to 1e8d10c Compare February 27, 2023 11:48

Nicklee007 force-pushed the rocksdb-compact branch from 1e8d10c to debd4bd Compare March 7, 2023 09:30

Nicklee007 force-pushed the rocksdb-compact branch 2 times, most recently from e7a2f4c to 2ac67b5 Compare March 7, 2023 09:59

Nicklee007 requested a review from hangc0276 March 8, 2023 02:13

hangc0276 modified the milestones: 4.17.0, 4.16.0 Mar 14, 2023

horizonzy reviewed Mar 14, 2023

View reviewed changes

Nicklee007 force-pushed the rocksdb-compact branch 2 times, most recently from 1b68806 to 9680afe Compare March 14, 2023 11:00

Add trigger entry location index rocksDB compact interface.

75f6fb8

Nicklee007 force-pushed the rocksdb-compact branch from 9680afe to 75f6fb8 Compare March 14, 2023 11:10

Nicklee007 removed the request for review from hangc0276 March 14, 2023 11:11

Nicklee007 requested review from horizonzy and hangc0276 and removed request for horizonzy March 14, 2023 11:11

horizonzy approved these changes Mar 14, 2023

View reviewed changes

hangc0276 approved these changes Mar 15, 2023

View reviewed changes

hangc0276 merged commit 0fa39b6 into apache:master Mar 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add trigger entry location index rocksDB compact REST API #3802

Add trigger entry location index rocksDB compact REST API #3802

Nicklee007 commented Feb 23, 2023

codecov-commenter commented Feb 23, 2023 •

edited

Loading

dlg99 left a comment

eolivelli left a comment

nicoloboschi left a comment

Nicklee007 commented Feb 27, 2023

hangc0276 left a comment

hangc0276 commented Feb 27, 2023

Nicklee007 commented Mar 7, 2023

horizonzy left a comment

Nicklee007 commented Mar 14, 2023

Add trigger entry location index rocksDB compact REST API #3802

Add trigger entry location index rocksDB compact REST API #3802

Conversation

Nicklee007 commented Feb 23, 2023

Motivation

Changes

codecov-commenter commented Feb 23, 2023 • edited Loading

Codecov Report

dlg99 left a comment

Choose a reason for hiding this comment

eolivelli left a comment

Choose a reason for hiding this comment

nicoloboschi left a comment

Choose a reason for hiding this comment

Nicklee007 commented Feb 27, 2023

hangc0276 left a comment

Choose a reason for hiding this comment

hangc0276 commented Feb 27, 2023

Nicklee007 commented Mar 7, 2023

horizonzy left a comment

Choose a reason for hiding this comment

Nicklee007 commented Mar 14, 2023

codecov-commenter commented Feb 23, 2023 •

edited

Loading