Skip sync the RocksDB when no changes #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
dlg99,
eolivelli,
shoothzj,
zymap and
StevenLuMT
zymap
approved these changes
Apr 6, 2023
|
@hangc0276 Do you want to update this PR to merge? |
merlimat
approved these changes
Jan 5, 2024
hangc0276
added a commit
to hangc0276/bookkeeper
that referenced
this pull request
Jan 18, 2024
Co-authored-by: Matteo Merli <mmerli@apache.org> ### Motivation For the `LedgerMetadataIndex#removeDeletedLedgers` and `LedgerMetadataIndex#flush`, it will call ledgersDB sync whether the ledgersDB has changed or not. We can skip the sync call when nothing changed in the ledgersDB. ### Changes - Check whether pendingLedgersUpdates is empty in `flush()` and `pendingDeletedLedgers` is empty in removeDeletedLedgers - Move the `key.recycle()` in finally to cover keys leak when the ledgersDB operations throw an exception. (cherry picked from commit 24464ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the
LedgerMetadataIndex#removeDeletedLedgersandLedgerMetadataIndex#flush, it will call ledgersDB sync whether the ledgersDB has changed or not. We can skip the sync call when nothing changed in the ledgersDB.Changes
flush()andpendingDeletedLedgersis empty in removeDeletedLedgerskey.recycle()in finally to cover keys leak when the ledgersDB operations throw an exception.