Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup CbThreadFactory #3907

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Cleanup CbThreadFactory #3907

merged 2 commits into from
Apr 12, 2023

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Apr 7, 2023

Descriptions of the changes in this PR:

Motivation

Cleanup CbThreadFactory because it's unused

Changes

Cleanup CbThreadFactory

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Apr 7, 2023

rerun failure checks

2 similar comments
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Apr 7, 2023

rerun failure checks

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Apr 7, 2023

rerun failure checks

@AnonHxy AnonHxy closed this Apr 8, 2023
@AnonHxy AnonHxy reopened this Apr 8, 2023
@hangc0276 hangc0276 added this to the 4.17.0 milestone Apr 10, 2023
horizonzy
horizonzy approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merlimat merlimat merged commit 912896d into apache:master Apr 12, 2023
zymap pushed a commit that referenced this pull request Jun 19, 2023
@AnonHxy @zymap
Cleanup CbThreadFactory (#3907)
d3f8aa3 
* Cleanup CbThreadFactory

* checkstyle

(cherry picked from commit 912896d)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@AnonHxy
Cleanup CbThreadFactory (apache#3907)
ba07d28 
* Cleanup CbThreadFactory

* checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@jiazhai jiazhai jiazhai approved these changes

@horizonzy horizonzy horizonzy approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

@zymap zymap Awaiting requested review from zymap

@StevenLuMT StevenLuMT Awaiting requested review from StevenLuMT

Assignees

@AnonHxy AnonHxy

Labels
cherry-picked/branch-4.16 release/4.16.2 type/cleanup
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AnonHxy @hangc0276 @jiazhai @horizonzy @merlimat