fix wrong update checkAllLedgersTime when ledgerReplication disabled #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Apr 26, 2023
|
rerun failure checks |
dlg99
approved these changes
Apr 27, 2023
hangc0276
approved these changes
Apr 27, 2023
zymap
pushed a commit
that referenced
this pull request
Jun 19, 2023
…3939) ### Motivation When ledgerReplication disabled, we don't need to register `checkAllLedgersTime` failedEvent because we already skipped the check and didn't encounter any exception. ```java Stopwatch stopwatch = Stopwatch.createStarted(); boolean checkSuccess = false; try { if (!isLedgerReplicationEnabled()) { LOG.info("Ledger replication disabled, skipping checkAllLedgers"); checkSuccess = true; <= here return; } LOG.info("Starting checkAllLedgers"); checkAllLedgers(); ...... checkSuccess = true; } catch (InterruptedException ie) { ...... } finally { if (!checkSuccess) { long checkAllLedgersDuration = stopwatch.stop().elapsed(TimeUnit.MILLISECONDS); auditorStats.getCheckAllLedgersTime() .registerFailedEvent(checkAllLedgersDuration, TimeUnit.MILLISECONDS); } } ``` (cherry picked from commit c765aea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When ledgerReplication disabled, we don't need to register
checkAllLedgersTimefailedEvent because we already skipped the check and didn't encounter any exception.