Optimize getEntryLogMetadata #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun failure checks |
1 similar comment
|
rerun failure checks |
hangc0276
reviewed
May 9, 2023
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java
Outdated
Show resolved
Hide resolved
|
rerun failure checks |
horizonzy
reviewed
May 10, 2023
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java
Outdated
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java
Outdated
Show resolved
Hide resolved
horizonzy
reviewed
May 14, 2023
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java
Outdated
Show resolved
Hide resolved
|
rerun failure checks |
wenbingshen
approved these changes
May 19, 2023
hangc0276
approved these changes
May 22, 2023
hangc0276
requested review from
eolivelli,
StevenLuMT,
horizonzy and
zymap
and removed request for
horizonzy
zymap
approved these changes
Jun 25, 2023
|
rerun failure checks |
StevenLuMT
approved these changes
Jul 3, 2023
zymap
pushed a commit
that referenced
this pull request
Aug 29, 2023
###Motivation In the `getEntryLogMetadata` method, the `FileNotFoundException` exception is caught before the more general Exception. This modification ensures that if the log file is not found, there is no need to proceed with the `extractEntryLogMetadataByScanning(entryLogId, throttler)` method call. This enhancement improves the code's error handling by distinguishing between different exceptions that may occur during the retrieval of entry log metadata. It ensures that unnecessary operations, scanning the log, are skipped when the log file is not found. (cherry picked from commit 69f27b7)
zymap
pushed a commit
that referenced
this pull request
Dec 6, 2023
###Motivation In the `getEntryLogMetadata` method, the `FileNotFoundException` exception is caught before the more general Exception. This modification ensures that if the log file is not found, there is no need to proceed with the `extractEntryLogMetadataByScanning(entryLogId, throttler)` method call. This enhancement improves the code's error handling by distinguishing between different exceptions that may occur during the retrieval of entry log metadata. It ensures that unnecessary operations, scanning the log, are skipped when the log file is not found. (cherry picked from commit 69f27b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
getEntryLogMetadatamethod, theFileNotFoundExceptionexception is caught before the more general Exception. This modification ensures that if the log file is not found, there is no need to proceed with theextractEntryLogMetadataByScanning(entryLogId, throttler)method call.This enhancement improves the code's error handling by distinguishing between different exceptions that may occur during the retrieval of entry log metadata. It ensures that unnecessary operations, scanning the log, are skipped when the log file is not found.