Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recycle LongWrapper finally to avoid memory leak #4007

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Jun 30, 2023

Descriptions of the changes in this PR:

Motivation

We should recycle LongWrapper in finally block to avoid memory leak. Beacuase flush() and removeDeletedLedgers() could throw Exception.

Changes

Recycle LongWrapper in finally block

@AnonHxy AnonHxy changed the title Recycle LongWrapper finally Recycle LongWrapper finally to avoid memory leak Jun 30, 2023
Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jul 3, 2023

rerun failure checks

Copy link
Contributor

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jul 5, 2023

rerun failure checks

@StevenLuMT StevenLuMT merged commit 528f373 into apache:master Jul 10, 2023
16 checks passed
zymap pushed a commit that referenced this pull request Aug 29, 2023
(cherry picked from commit 528f373)
zymap pushed a commit that referenced this pull request Dec 7, 2023
(cherry picked from commit 528f373)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants