New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read failed log for ledger checker. #4010
Add read failed log for ledger checker. #4010
Conversation
rerun failure checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for modifying the fifth parameter of bookieClient.readEntry?
I couldn't see it's motivation in this PR
In the callback, we need to print the bookie. So we need the bookie as the ctx. |
@StevenLuMT Can you help take a look at this comment? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Descriptions of the changes in this PR:
The ledger checker will try to read entries from the bookie. If the read failed, mark the ledger as under-replicated.
For users, they didn't know the reason why the ledger mark as under-replicated. Is it because the entry is missing, the ledger does not exist, or because the bookie is under heavy load and the read request times out?
So here we add debug log for ledger checker. If read failed, log the error code.