Issue 356: Release notes 4.5.0 #402
Conversation
sijie
requested review from
jvrao,
merlimat,
jiazhai,
eolivelli and
reddycharan
|
https://sijie.github.io/bookkeeper-staging-site/docs/latest/releaseNotes/ for easy to review |
|
+1 but made few more suggestions. |
|
+1 look great to me. |
site/docs/latest/releaseNotes.md
Outdated
| @@ -0,0 +1,483 @@ | |||
| --- | |||
There was a problem hiding this comment.
Can we add all upgrades we did?
Upgrade protobuf to 2.6
Codehale to 3.1.0
ZK to version 3.5
Move to JDK 8
SLF4J to 7.25
Netty 4.1
Guava to version 20.0
|
+1 look great to me. |
site/docs/latest/releaseNotes.md
Outdated
|
|
||
| ### Performance | ||
|
|
||
| There are a lot for performance related bug fixes and improvements in 4.5.0. The major performance improvement introduced in 4.5.0, is |
There was a problem hiding this comment.
I think there are lot more perf improvements related to caching additional metadata, avoiding buffer copies, taking advantage of java8 features, scheduling and threading improvements etc. Ledger recovery improvements. We should discuss these.
There was a problem hiding this comment.
I added a paragraph at the beginning of performance section.
site/docs/latest/releaseNotes.md
Outdated
| #### Add Prometheus stats provider | ||
|
|
||
| A new [Prometheus](https://prometheus.io/) [stats provider](https://github.com/apache/bookkeeper/tree/master/bookkeeper-stats-providers/prometheus-metrics-provider) | ||
| is introduce in 4.5.0. It simplies the metric collection when running bookkeeper on [kubernetes](https://kubernetes.io/). |
There was a problem hiding this comment.
We made ton of test improvements. We need to mention that too.
There was a problem hiding this comment.
We may need to talk about tool improvements too?
There was a problem hiding this comment.
I don't think test improvements need to be in highlights.
I will include the tool improvements.
|
@eolivelli we shaded guava since 4.4. it is not actually new to 4.5. I would prefer we documenting somewhere, rather than including it in 4.5 release notes. The 4.5 release notes should focus on the changes in 4.5, it is not a documentation. |
|
addressed the comments. please take a look again. |
|
@sijie with these changes it looks good. |
|
I forgot to mention networkless bookie but I think it does not make sense yet for the general audience |
1 similar comment
|
I forgot to mention networkless bookie but I think it does not make sense yet for the general audience |
|
update the release notes |
|
release notes are ready to merge now. |
Descriptions of the changes in this PR: - summary for release 4.5.0 - highlights for 4.5.0 - full list of JIRA and Github issues. Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Matteo Merli <mmerli@apache.org>, Venkateswararao Jujjuri (JV) <None> This closes apache#402 from sijie/release_notes_4.5.0, closes apache#356
Descriptions of the changes in this PR: - summary for release 4.5.0 - highlights for 4.5.0 - full list of JIRA and Github issues. Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Matteo Merli <mmerli@apache.org>, Venkateswararao Jujjuri (JV) <None> This closes #402 from sijie/release_notes_4.5.0, closes #356
Descriptions of the changes in this PR: