New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 356: Release notes 4.5.0 #402

Closed
wants to merge 10 commits into
base: master
from

Conversation

@sijie
Contributor

sijie commented Aug 7, 2017

Descriptions of the changes in this PR:

  • summary for release 4.5.0
  • highlights for 4.5.0
  • full list of JIRA and Github issues.

@sijie sijie added this to the 4.5.0 milestone Aug 7, 2017

@sijie sijie self-assigned this Aug 7, 2017

@sijie

This comment has been minimized.

Show comment
Hide comment
Contributor

sijie commented Aug 7, 2017

@jiazhai

jiazhai approved these changes Aug 7, 2017

+1. 👍

@jvrao

This comment has been minimized.

Show comment
Hide comment
@jvrao

jvrao Aug 7, 2017

Contributor

+1 but made few more suggestions.

Contributor

jvrao commented Aug 7, 2017

+1 but made few more suggestions.

@eolivelli

This comment has been minimized.

Show comment
Hide comment
@eolivelli

eolivelli Aug 7, 2017

Contributor

+1 look great to me.
I don't remember that in 4.4 it was possible to use digest md5 auth

Contributor

eolivelli commented Aug 7, 2017

+1 look great to me.
I don't remember that in 4.4 it was possible to use digest md5 auth

@eolivelli

This comment has been minimized.

Show comment
Hide comment
@eolivelli

eolivelli Aug 7, 2017

Contributor

+1 look great to me.
I don't remember that in 4.4 it was possible to use digest md5 auth.
About guava we should tell that we are shading it and it is used only internally, users will be able to use any version of that library

Contributor

eolivelli commented Aug 7, 2017

+1 look great to me.
I don't remember that in 4.4 it was possible to use digest md5 auth.
About guava we should tell that we are shading it and it is used only internally, users will be able to use any version of that library

@sijie

This comment has been minimized.

Show comment
Hide comment
@sijie

sijie Aug 8, 2017

Contributor

@eolivelli we shaded guava since 4.4. it is not actually new to 4.5. I would prefer we documenting somewhere, rather than including it in 4.5 release notes. The 4.5 release notes should focus on the changes in 4.5, it is not a documentation.

Contributor

sijie commented Aug 8, 2017

@eolivelli we shaded guava since 4.4. it is not actually new to 4.5. I would prefer we documenting somewhere, rather than including it in 4.5 release notes. The 4.5 release notes should focus on the changes in 4.5, it is not a documentation.

@sijie

This comment has been minimized.

Show comment
Hide comment
@sijie

sijie Aug 8, 2017

Contributor

addressed the comments. please take a look again.

Contributor

sijie commented Aug 8, 2017

addressed the comments. please take a look again.

@eolivelli

This comment has been minimized.

Show comment
Hide comment
@eolivelli

eolivelli Aug 8, 2017

Contributor

+1 Still okay for me.

Just to be clear, this is the patch for guava relocation and it is for 4.5
#166

Thank you @sijie

Contributor

eolivelli commented on 2771e6e Aug 8, 2017

+1 Still okay for me.

Just to be clear, this is the patch for guava relocation and it is for 4.5
#166

Thank you @sijie

@jvrao

This comment has been minimized.

Show comment
Hide comment
@jvrao

jvrao Aug 10, 2017

Contributor

@sijie with these changes it looks good.

Contributor

jvrao commented Aug 10, 2017

@sijie with these changes it looks good.

@eolivelli

This comment has been minimized.

Show comment
Hide comment
@eolivelli

eolivelli Aug 10, 2017

Contributor

I forgot to mention networkless bookie but I think it does not make sense yet for the general audience

Contributor

eolivelli commented Aug 10, 2017

I forgot to mention networkless bookie but I think it does not make sense yet for the general audience

@eolivelli

This comment has been minimized.

Show comment
Hide comment
@eolivelli

eolivelli Aug 10, 2017

Contributor

I forgot to mention networkless bookie but I think it does not make sense yet for the general audience

Contributor

eolivelli commented Aug 10, 2017

I forgot to mention networkless bookie but I think it does not make sense yet for the general audience

@sijie

This comment has been minimized.

Show comment
Hide comment
@sijie

sijie Aug 10, 2017

Contributor

update the release notes

Contributor

sijie commented Aug 10, 2017

update the release notes

@sijie

This comment has been minimized.

Show comment
Hide comment
@sijie

sijie Aug 10, 2017

Contributor

release notes are ready to merge now.

Contributor

sijie commented Aug 10, 2017

release notes are ready to merge now.

@sijie sijie closed this in 3ebd429 Aug 10, 2017

caiok added a commit to caiok/bookkeeper that referenced this pull request Aug 11, 2017

ISSUE #356: Release notes 4.5.0
Descriptions of the changes in this PR:

- summary for release 4.5.0
- highlights for 4.5.0
- full list of JIRA and Github issues.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Matteo Merli <mmerli@apache.org>, Venkateswararao Jujjuri (JV) <None>

This closes #402 from sijie/release_notes_4.5.0, closes #356

sijie added a commit that referenced this pull request Aug 11, 2017

ISSUE #356: Release notes 4.5.0
Descriptions of the changes in this PR:

- summary for release 4.5.0
- highlights for 4.5.0
- full list of JIRA and Github issues.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Matteo Merli <mmerli@apache.org>, Venkateswararao Jujjuri (JV) <None>

This closes #402 from sijie/release_notes_4.5.0, closes #356

@sijie sijie deleted the sijie:release_notes_4.5.0 branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment