Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read write request leak when executor throw RejectedExecutionException #4024

Conversation

lifepuzzlefun
Copy link
Contributor

No description provided.

Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor

@AnonHxy AnonHxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276
Copy link
Contributor

rerun failure checks

@hangc0276
Copy link
Contributor

@zymap Please help take a look at this PR, thanks.

zymap

This comment was marked as resolved.

Copy link
Member

@zymap zymap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276 hangc0276 closed this Aug 10, 2023
@hangc0276 hangc0276 reopened this Aug 10, 2023
@zymap zymap merged commit 0b0fe0b into apache:master Aug 29, 2023
31 of 32 checks passed
zymap pushed a commit that referenced this pull request Aug 29, 2023
Co-authored-by: wangjinlong <wangjinlong@zhihu.com>
(cherry picked from commit 0b0fe0b)
zymap pushed a commit that referenced this pull request Dec 7, 2023
Co-authored-by: wangjinlong <wangjinlong@zhihu.com>
(cherry picked from commit 0b0fe0b)
gaozhangmin pushed a commit to gaozhangmin/bookkeeper that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants