Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deletedLedgers count #4026

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fix deletedLedgers count #4026

merged 1 commit into from
Jul 21, 2023

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Jul 11, 2023

Descriptions of the changes in this PR:

Motivation

Fix deletedLedgers count. We should increase the deletedLedgers in the loop, otherwise it's value will always be zero

Changes

Increase the deletedLedgers in the loop

@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jul 14, 2023

@StevenLuMT @hangc0276 @eolivelli @dlg99 @merlimat PTAL

horizonzy
horizonzy approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangc0276 hangc0276 added this to the 4.17.0 milestone Jul 17, 2023
StevenLuMT
StevenLuMT approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StevenLuMT StevenLuMT merged commit 3bf08fe into apache:master Jul 21, 2023
16 checks passed
hangc0276 pushed a commit that referenced this pull request Aug 17, 2023
@AnonHxy @hangc0276
Fix deletedLedgers count (#4026)
2f3ab1c 
(cherry picked from commit 3bf08fe)
zymap pushed a commit that referenced this pull request Aug 29, 2023
@AnonHxy @zymap
Fix deletedLedgers count (#4026)
4c87a17 
(cherry picked from commit 3bf08fe)
zymap pushed a commit that referenced this pull request Dec 7, 2023
@AnonHxy @zymap
Fix deletedLedgers count (#4026)
01182f7 
(cherry picked from commit 3bf08fe)
gaozhangmin pushed a commit to gaozhangmin/bookkeeper that referenced this pull request Feb 20, 2024
Fix deletedLedgers count (apache#4026)
86340ce
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@AnonHxy
Fix deletedLedgers count (apache#4026)
d2de73a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@horizonzy horizonzy horizonzy approved these changes

@StevenLuMT StevenLuMT StevenLuMT approved these changes

@zymap zymap Awaiting requested review from zymap

@wenbingshen wenbingshen Awaiting requested review from wenbingshen

Assignees

@AnonHxy AnonHxy

Labels
cherry-picked/branch-4.14 cherry-picked/branch-4.15 cherry-picked/branch-4.16 release/4.14.8 release/4.15.5 release/4.16.3
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AnonHxy @hangc0276 @horizonzy @StevenLuMT @zymap