Make compatible between DefaultEntryLogger and DirectEntryLogger #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
reviewed
Jul 31, 2023
|
rerun failure checks |
4 tasks
zymap
reviewed
Aug 10, 2023
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java
Show resolved
Hide resolved
zymap
added
release/4.16.4
release/4.16.3
and removed
release/4.16.3
release/4.16.4
labels
zymap
approved these changes
Aug 30, 2023
zymap
pushed a commit
that referenced
this pull request
Aug 30, 2023
Descriptions of the changes in this PR: Fixes #4040 Upgrade guide: If the user already uses the DirectEntryLogger in production, can not disable DirectEntryLogger directly. There are two ways: 1. Upgrade to the version with this PR, and disable DirectEntryLogger. Then restart, and the data won't be lost. 2. If you don't want to upgrade to the bookie version, you should stop the bookie first, then find the entry log which has the biggest log id. Modify the `lastLogId` file content using the biggest log id. (Not recommend) --------- Co-authored-by: zymap <zhangyong1025.zy@gmail.com> (cherry picked from commit 2e8be78)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…che#4041) Descriptions of the changes in this PR: Fixes apache#4040 Upgrade guide: If the user already uses the DirectEntryLogger in production, can not disable DirectEntryLogger directly. There are two ways: 1. Upgrade to the version with this PR, and disable DirectEntryLogger. Then restart, and the data won't be lost. 2. If you don't want to upgrade to the bookie version, you should stop the bookie first, then find the entry log which has the biggest log id. Modify the `lastLogId` file content using the biggest log id. (Not recommend) --------- Co-authored-by: zymap <zhangyong1025.zy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Fixes #4040
Upgrade guide:
If the user already uses the DirectEntryLogger in production, can not disable DirectEntryLogger directly.
There are two ways:
lastLogIdfile content using the biggest log id. (Not recommend)