Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LedgerHandle ensembleChangeCounter not used. #4103

Merged

Conversation

lifepuzzlefun
Copy link
Contributor

@lifepuzzlefun lifepuzzlefun commented Oct 15, 2023

Motivation

fix #4096

ensemble change counter not inc when ensemble change .

Changes

inc counter when ensemble change.

@hangc0276
Copy link
Contributor

@lifepuzzlefun Would you please rebase the master? thanks.

@hangc0276
Copy link
Contributor

@lifepuzzlefun Would you please rebase the master? Thanks.

@lifepuzzlefun
Copy link
Contributor Author

@lifepuzzlefun Would you please rebase the master? Thanks.

sorry for the late reply. rebased master, please take a look : - )

@hangc0276 hangc0276 merged commit 13e7efa into apache:master Jan 8, 2024
16 checks passed
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Jan 18, 2024
### Motivation
fix apache#4096

ensemble change counter not inc when ensemble change .

### Changes
inc counter when ensemble change.

(cherry picked from commit 13e7efa)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
### Motivation
fix apache#4096

ensemble change counter not inc when ensemble change .

### Changes
inc counter when ensemble change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric stats NUM_ENSEMBLE_CHANGE is never used?
3 participants