Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed creation of temporary dir in NativeUtils #4262

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Apr 2, 2024

Motivation

Creating the temp directory for unpacking the native library is failing for the affinity library.

Changes

Use Files.createTempDirectory() instead.


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@merlimat merlimat added this to the 4.17.0 milestone Apr 2, 2024
@merlimat merlimat requested review from hangc0276 and zymap April 2, 2024 15:58
@merlimat merlimat self-assigned this Apr 2, 2024
@shoothzj shoothzj merged commit 07e3df9 into apache:master Apr 3, 2024
20 checks passed
@merlimat merlimat deleted the fix-native-temp-dir branch April 3, 2024 04:09
merlimat added a commit that referenced this pull request Apr 3, 2024
### Motivation

Creating the temp directory for unpacking the native library is failing for the affinity library.

### Changes

Use `Files.createTempDirectory()` instead.
merlimat added a commit that referenced this pull request Apr 3, 2024
### Motivation

Creating the temp directory for unpacking the native library is failing for the affinity library.

### Changes

Use `Files.createTempDirectory()` instead.
@hangc0276 hangc0276 modified the milestones: 4.17.0, 4.18.0 Apr 22, 2024
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
### Motivation

Creating the temp directory for unpacking the native library is failing for the affinity library.

### Changes

Use `Files.createTempDirectory()` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants