Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: remove duplicate forceGarbageCollection setValue in run method #4303

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

shoothzj
Copy link
Member

Motivation

remove duplicate forceGarbageCollection setValue, it is redundant and error-prone. It's already seted in

} finally {
if (force && forceGarbageCollection.compareAndSet(true, false)) {
LOG.info("{} Set forceGarbageCollection to false after force GC to make it forceGC-able again.",
Thread.currentThread().getName());
}
}

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
Copy link
Contributor

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shoothzj
Copy link
Member Author

@shoothzj shoothzj merged commit d7328a5 into apache:master Apr 29, 2024
20 checks passed
@shoothzj shoothzj deleted the remove-stale-code branch April 29, 2024 05:48
@hangc0276 hangc0276 added this to the 4.18.0 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants