Disable two tests in BookKeeperTest on JDK 17+ due to UnsupportedOperationException #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoothzj
force-pushed
the
bkkeeper-test-method-jdk17
branch
2 times, most recently
from
bcc5004
to
991d64a
Compare
dlg99
reviewed
May 7, 2024
There was a problem hiding this comment.
Thank you for picking this up!
Overall this LGTM but the change calls for addition of the "Compatibility Check" CI job with JDK 21 (LTS), otherwise I can't really look at the PR and tell that the fix works. Also this way we won't break this in the future.
See
bookkeeper/.github/workflows/bk-ci.yml
Lines 441 to 448 in 1ae4be0
and
Lines 54 to 56 in 1ae4be0
dlg99
approved these changes
May 8, 2024
…ationException Signed-off-by: ZhangJian He <shoothzj@gmail.com>
shoothzj
force-pushed
the
bkkeeper-test-method-jdk17
branch
from
991d64a
to
1b1e530
Compare
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…ationException (apache#4347) ### Motivation JDK 17 and later throw `UnsupportedOperationException` for the `suspend` and `resume` methods, causing the `testConstructionZkDelay` and `testConstructionNotConnectedExplicitZk` tests to fail. See jdk21 daily build error: https://github.com/apache/bookkeeper/actions/runs/8962118072 ### Changes - Disabled the two affected test methods for JDK 17 and above using the `@EnabledForJreRange` annotation. - Transitioned to JUnit 5 annotations and assertions. ### Q&A Q: why there are so many line changes? like format change A: In junit5, the msg should be put in the latest param, related to some changes. Signed-off-by: ZhangJian He <shoothzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
JDK 17 and later throw
UnsupportedOperationExceptionfor thesuspendandresumemethods, causing thetestConstructionZkDelayandtestConstructionNotConnectedExplicitZktests to fail.See jdk21 daily build error: https://github.com/apache/bookkeeper/actions/runs/8962118072
Changes
@EnabledForJreRangeannotation.Q&A
Q: why there are so many line changes? like format change
A: In junit5, the msg should be put in the latest param, related to some changes.