test: fix bkHttpServiceProvider not closed in TestHttpService #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
shoothzj
force-pushed
the
bkHttpServiceProvider-close
branch
from
7b9ff97
to
6c3bc8d
Compare
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…#4349) Signed-off-by: ZhangJian He <shoothzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue: may related to #1614
Motivation
The
bkHttpServiceProviderwas not being closed after the completion of the test cases inTestHttpService.Changes
junit.jupiter.api.@AfterEachmethod to closebkHttpServiceProviderafter each test run.assertTrue,assertFalse,assertNull, andassertEqualsmethods.